Opened 9 years ago
Last modified 6 years ago
#36765 new defect (bug)
Remove Legacy Code from pingback_ping
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 4.1 |
Component: | Pings/Trackbacks | Keywords: | has-patch dev-feedback needs-unit-tests |
Focuses: | Cc: |
Description (last modified by )
Attachments (3)
Change History (10)
This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.
9 years ago
This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.
9 years ago
#3
@
9 years ago
- Keywords needs-refresh added
- Milestone changed from Awaiting Review to Future Release
@dshanske your latest patch 36765.2.diff contains style edits for lines you are not editing. Your patch should only include code changes, not additional refactoring. See: https://make.wordpress.org/core/handbook/contribute/code-refactoring/
#4
@
9 years ago
- Keywords has-patch dev-feedback added; needs-refresh removed
Fixed per feedback by @rachelbaker
This ticket was mentioned in Slack in #core-comments by dshanske. View the logs.
9 years ago
#6
@
9 years ago
- Keywords needs-unit-tests added
@dshanske this is looking good so far. Are there any conditions covered by the duplicate logic you are removing in this ticket that are not covered by url_to_post_id()
? Would be good to check the tests in trunk/tests/phpunit/tests/rewrite.php, and add any conditions that are missing.
Revert conditional based on feedback