Opened 9 years ago
Closed 7 years ago
#36884 closed defect (bug) (fixed)
Customizer child menus incorrectly resize the site to an incorrect minimum-width
Reported by: | kwonye | Owned by: | adamsilverstein |
---|---|---|---|
Milestone: | 4.9.5 | Priority: | normal |
Severity: | normal | Version: | 4.4 |
Component: | Customize | Keywords: | has-patch commit fixed-major |
Focuses: | ui, administration | Cc: |
Description
On Chrome for Android, creating a child menu in the Customizer expands the width of the page to a min-width: 950px, !important
(at least on my device)
Repro steps:
1) Go to dashboard > Themes >Customize.
2) Go to Menus > click 'Add a Menu' > Create Menu
3) Add Items (at least two) and back out
4) Drag one of the items to the right to be a child menu.
5) Screen resizes
Attachments (4)
Change History (21)
#3
@
9 years ago
@adamsilverstein
Happened on two devices:
Device: Samsung Galaxy S6 Edge+
Android version: 5.1.1
Device: Nexus 6P
Android version: 6.0.1
(also, images attached)
#4
@
9 years ago
In 36884.diff :
Ensure body min width not applied when editing menus in customize; fixes an issue where screen resized to an oversize state on mobile devices when adding sub-menus.
#6
follow-up:
↓ 7
@
9 years ago
- Owner set to adamsilverstein
- Status changed from new to assigned
- Version changed from 4.5.2 to 4.4
@kwonye thanks again for raising this issue; the patch I attached fixes it, can you give it a test? Pretty sure this issue has existed since we introduced menus in the customizer in WordPress 4.4.
#7
in reply to:
↑ 6
@
9 years ago
Replying to adamsilverstein:
@kwonye thanks again for raising this issue; the patch I attached fixes it, can you give it a test? Pretty sure this issue has existed since we introduced menus in the customizer in WordPress 4.4.
Fix looks great, thanks @adamsilverstein!
#8
@
7 years ago
Thanks for confirming @kwonye - I'm going to-test this to see if its still and iss and if the fix still works.
#9
@
7 years ago
- Keywords commit added; needs-testing removed
- Milestone changed from Awaiting Review to 4.9.5
Confirmed the issue still exists and the patch still fixes it. refreshed against trunk in 36884.2.diff.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
7 years ago
#12
@
7 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for 4.9.5 consideration.
This ticket was mentioned in Slack in #core by danieltj. View the logs.
7 years ago
#14
@
7 years ago
Hello,
This ticket was mentioned during 4.9.5 bug scrub.
I tested the patch and it seems ready to land in 4.9.5.
Hello @kwonye, thanks for the bug report!
Can you give some more details about your device, what is the specific model/version? Also, if possible please add a screenshot showing what you see when this issue occurs.
Thanks!