WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 5 months ago

#36885 new defect (bug)

When one uses custom callback function for comment list, "Reply" link would not show

Reported by: remedy17 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Comments Keywords: reporter-feedback
Focuses: template Cc:
PR Number:

Description

It took too much time, but found the issue here in wp-includes/comments-template.php in
get_comment_reply_link function. The OR conditions are likely to be true I imagine in many combination of situations although I am not too sure what combination causes bad things to happen.


if ( 0 == $args['depth'] || $args['max_depth'] <= $args['depth'] ) {
		return;
	}

Well and good to check this, but why would the reply as well as login link disappear if any of it is true? Sorry if I am not getting this as I should.

Change History (1)

#1 @ocean90
3 years ago

  • Keywords reporter-feedback added
  • Version trunk deleted

Hello @remedy17, welcome to our Trac!

but why would the reply as well as login link disappear if any of it is true?

The function shouldn't return a link if the maximum depth for threaded comments is reached since the user can't reply to that comment anymore. They have to use a comment one level higher.

What's the value of get_option('thread_comments_depth') or $args['max_depth']?

Note: See TracTickets for help on using tickets.