WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#36896 closed defect (bug) (fixed)

Improve docs for the return value of WP_Comment_Query::get_comments()

Reported by: ocean90 Owned by: barryceelen
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Comments Keywords: good-first-bug has-patch commit
Focuses: docs Cc:
PR Number:

Description

Currently: "@return int|array The list of comments." It should explain when the function returns an integer.

Attachments (2)

36690.diff (1.4 KB) - added by barryceelen 3 years ago.
36896.1.diff (524 bytes) - added by barryceelen 3 years ago.

Download all attachments as: .zip

Change History (8)

@barryceelen
3 years ago

#1 @barryceelen
3 years ago

  • Keywords has-patch added; needs-patch removed

#2 @ocean90
3 years ago

  • Keywords needs-patch added; has-patch removed

@barryceelen Looks like you uploaded the wrong patch.

#3 @barryceelen
3 years ago

Oops! yes indeed.

@barryceelen
3 years ago

#4 @barryceelen
3 years ago

  • Keywords has-patch added; needs-patch removed

#5 @ocean90
3 years ago

  • Keywords commit added
  • Milestone changed from Future Release to 4.6
  • Owner set to barryceelen
  • Status changed from new to assigned

Thanks @barryceelen!

#6 @boonebgorges
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37482:

Improve @return documentation for WP_Comment_Query::get_comments().

Props barryceelen.
Fixes #36896.

Note: See TracTickets for help on using tickets.