WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#36975 closed enhancement (fixed)

Network upgrade screen should skip certificate verification

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.6 Priority: normal
Severity: normal Version: 3.0
Component: Upgrade/Install Keywords: has-patch commit
Focuses: multisite Cc:
PR Number:

Description

For the same reason that certificate verification was removed from the cron spawner in #12609, certificate verification should be skipped (sslverify=>false) when upgrading a network's sites from wp-admin/network/upgrade.php. Sites using a self-signed or otherwise invalid cert will fail to upgrade otherwise.

Attachments (1)

36975.diff (633 bytes) - added by johnbillion 4 years ago.

Download all attachments as: .zip

Change History (8)

@johnbillion
4 years ago

#1 @johnbillion
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.6

#2 @ajv9540
4 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

#3 @swissspidy
4 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

#4 @johnjamesjacoby
4 years ago

  • Keywords commit added

I haven't ran into this yet, but I can imagine it happening and not being real happy about it.

+1

#5 @chriscct7
4 years ago

  • Owner set to johnbillion
  • Status changed from reopened to assigned

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


4 years ago

#7 @johnbillion
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37695:

Upgrade/Install: Skip certificate verification when upgrading a network's sites. This avoids issues with self-signed certificates or otherwise invalid certificates.

Fixes #36975

Note: See TracTickets for help on using tickets.