Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 4 days ago

#3708 closed defect (bug) (wontfix)

wp_login is too "friendly" -- Information disclosure

Reported by: charleshooper Owned by:
Milestone: Priority: low
Severity: trivial Version: 2.2
Component: Security Keywords: security login has-patch
Focuses: Cc:


While it's not exactly the end of the world, if you attempt to login with an invalid username the error message returned is actually "Invalid username." Obviously it works as intended; However, I consider this information disclosure and feel that invalid usernames and passwords should both return the same error message.

Attachments (1)

wp_login.diff (961 bytes) - added by charleshooper 8 years ago.
"Fix" for ticket #3708

Download all attachments as: .zip

Change History (11)

@charleshooper8 years ago

"Fix" for ticket #3708

comment:1 @charleshooper8 years ago

  • Keywords has-patch added; error removed

comment:2 @charleshooper8 years ago

  • Milestone changed from 2.3 to 2.2
  • Version set to 2.2

comment:3 @markjaquith8 years ago

There are other ways to verify user names. You can reverse engineer them from the author archive URLs (e.g. http://example.com/author/mark/). I believe the consensus last time this came up was that it was trivial to figure out the user names anyway, and that it is much more user-friendly to tell them when they messed up their username, and not the password. Also, "admin" is created on install, and can't be changed using WordPress itself, so there's no hiding that.

comment:4 @charleshooper8 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Good point about the author archives, I hadn't really thought about that. Guess I was just excited about submitting my first patch for Wordpress, even IF it was only to change some error messages.

But now that I've been reminded that there are many other ways to get valid Wordpress usernames (that are all quite a bit easier than brute forcing the login) it just doesn't make sense to leave this ticket hanging.

comment:5 @foolswisdom8 years ago

  • Milestone 2.2 deleted

comment:6 @SergeyBiryukov2 years ago

#22421 was marked as a duplicate.

comment:7 @helen14 months ago

#27125 was marked as a duplicate.

comment:8 @slackbot2 months ago

This ticket was mentioned in Slack in #forums by dmchale. View the logs.

comment:9 @slackbot2 months ago

This ticket was mentioned in Slack in #core by dmchale. View the logs.

comment:10 @voldemortensen4 days ago

#31787 was marked as a duplicate.

Note: See TracTickets for help on using tickets.