wp_print_admin_notice_templates() does not use _n*() for plural forms

[ideag]

Function wp_print_admin_notice_templates() (https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/update.php#L615) does not properly use _n() and related functions for plural forms of its strings. It just makes a simple if (count ===1) check and uses two different strings - one for singular, one for plural form.

This presents a problem when translating into languages that have more than one plural form, or more complicated rules for singular form usage. For example, in Lithuanian we also use singular form for 21, 1241 and any other number that ends with 1 (except for 11). And we have two plural forms - one for numbers ending with a zero, another for everything else. In current situation we can not have a proper translation here.

[ideag]

OK, as I understand, this will not get fixed until #20491 gets fixed. So not in time for 4.6 or anything like it. Just use generic strings.

[SergeyBiryukov]

Noticed the same when translating yesterday. Yes, it depends on #20491 to be implemented properly (we can't just use _n() here, as it's a JS template).

For now, I would use some kind of a workaround in translation, e.g. "Plugins (%s) successfully updated".

[ideag]

Replying to SergeyBiryukov:

Noticed the same when translating yesterday. Yes, it depends on #20491 to be implemented properly (we can't just use _n() here, as it's a JS template).

For now, I would use some kind of a workaround in translation, e.g. "Plugins (%s) successfully updated".

Well, we could hold of on introducing faulty logic into the core and use generic strings right there.
But I guess shiny updates have to be, well, shiny. At least in English :)

I haven't looked into where data.successes comes from, but if it originates in PHP, maybe we could pass a pluralized string to it readily instead of having that logic in JavasScript at all? OK, I see we can't do that here.

[swissspidy]

#37811 was marked as a duplicate.

This PR updates the template used for bulk updates to use client-side localisation via wp.i18n._n() to handle plurals correctly. I do have some concerns, though:

• Will these translations be correctly picked up now that they're in server code that is using the client-side functions?
• What is the correct way to add translation comments for the code approach above?

Trac ticket: https://core.trac.wordpress.org/ticket/37287

[audrasjb]

After patch: singular form - works fine

[audrasjb]

After patch: plural form - works fine

[audrasjb]

The patch works fine on my side.

pinging @SergeyBiryukov for additional review, but I think we're good to go with ​PR2778.

[audrasjb]

Self assigning for commit.

[audrasjb]

In 54469:

I18N: Use wp.i18n._n() for plural forms in wp_print_admin_notice_templates().

This changeset adds better support for plural forms in update admin notices generated on the Themes and Plugins screens. This fixes issues when translating into languages that have more than one plural form, or more complicated rules for singular form usage.

Props ideag, SergeyBiryukov, daledupreez, audrasjb.
Fixes #37287.

[ocean90]

Reopening and suggesting revert of [54469] for now since there's currently no support for parsing JS i18n functions in PHP files which means the strings won't be translatable.

[audrasjb]

Oh, alright, I'm reverting it right now.
I'll move it to Future Release after it's reverted. Thanks.

[audrasjb]

In 54473:

I18N: Revert [54469].

This changeset reverts [54469] as there is currently no support for parsing JS i18n functions in PHP files which means the strings won't be translatable.

Props ocean90.
Unprops audrasjb.
See #37287.

[daledupreez]

Thanks for flagging that gap, @ocean90! This was one of my original concerns with my PR.

Do you know if we have an issue for adding that support to our translation tools? I'd like to make sure we flag this issue as blocked by that support (or possibly a motivator for adding it!).

[ocean90]

@daledupreez I think the proper solution would be to move this somehow into the existing JavaScript file instead of having this template in PHP.