WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#37345 closed defect (bug) (invalid)

register_meta has unclear error messages

Reported by: rmccue Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.6
Component: Options, Meta APIs Keywords: needs-patch dev-feedback
Focuses: Cc:

Description

Added in #35658.

Working through translations with @petya, the error messages we added are hard to translate and unclear in English as well. These should be clarified for both English users and to ease translation. The different errors should have different codes as well.

Attachments (3)

37345.patch (1.6 KB) - added by vishalkakadiya 4 years ago.
I think user can more understand this kind of error messages(see in patch).
37345_1.patch (2.0 KB) - added by vishalkakadiya 4 years ago.
37345_2.patch (5.5 KB) - added by vishalkakadiya 4 years ago.
@@rmccue I think "37345.patch" will work for you. Let me know if anything else change you want.

Download all attachments as: .zip

Change History (12)

#1 @petya
4 years ago

Just to clarify, we were looking at these strings:

Detailed translator comments for these strings can also help non-developer translators understand and localize them better.

#2 @ocean90
4 years ago

  • Keywords needs-patch added

@vishalkakadiya
4 years ago

I think user can more understand this kind of error messages(see in patch).

#3 @rmccue
4 years ago

Rather than WP_Errors, these should probably also be _doing_it_wrong errors, as they're compile-time, not runtime. Right now, it's easy to ignore the returned value too. I'd be happy with a _doing_it_wrong(...); return false;

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


4 years ago

#5 @jeremyfelt
4 years ago

  • Keywords dev-feedback added
  • Milestone changed from Awaiting Review to 4.6

@vishalkakadiya
4 years ago

@@rmccue I think "37345.patch" will work for you. Let me know if anything else change you want.

#6 @vishalkakadiya
4 years ago

@rmccue

Sorry ignore previous comment and I think "37345_2.patch" will work for you. Let me know if anything else change you want. Thanks!

Last edited 4 years ago by vishalkakadiya (previous) (diff)

#7 @jeremyfelt
4 years ago

Thanks for the patches @vishalkakadiya and thanks for the ticket @rmccue and @petya! Based on the direction #35658 is going, there's a chance we won't be using error messages at all. That will need to be resolved first before we tackle this one. :)

#8 @ocean90
4 years ago

#37401 was marked as a duplicate.

#9 @jeremyfelt
4 years ago

  • Milestone 4.6 deleted
  • Resolution set to invalid
  • Status changed from new to closed

These error messages were removed completely in [38095].

Note: See TracTickets for help on using tickets.