register_meta has unclear error messages

[rmccue]

Added in #35658.

Working through translations with @petya, the error messages we added are hard to translate and unclear in English as well. These should be clarified for both English users and to ease translation. The different errors should have different codes as well.

[petya]

Just to clarify, we were looking at these strings:

• Meta can only be registered against a core object type. - https://core.trac.wordpress.org/browser/trunk/src/wp-includes/meta.php#L1105
• Meta must be registered against an object subtype. - https://core.trac.wordpress.org/browser/trunk/src/wp-includes/meta.php#L1066
• Sanitize and auth callbacks registered; meta key not registered. - https://core.trac.wordpress.org/browser/trunk/src/wp-includes/meta.php#L1105
• Invalid meta key. Not a core object type. https://core.trac.wordpress.org/browser/trunk/src/wp-includes/meta.php#L1129, https://core.trac.wordpress.org/browser/trunk/src/wp-includes/meta.php#L1228

Detailed translator comments for these strings can also help non-developer translators understand and localize them better.

[vishalkakadiya]

I think user can more understand this kind of error messages(see in patch).

[rmccue]

Rather than WP_Errors, these should probably also be _doing_it_wrong errors, as they're compile-time, not runtime. Right now, it's easy to ignore the returned value too. I'd be happy with a _doing_it_wrong(...); return false;

[vishalkakadiya]

@@rmccue I think "37345.patch" will work for you. Let me know if anything else change you want.

[vishalkakadiya]

@rmccue

Sorry ignore previous comment and I think "37345_2.patch" will work for you. Let me know if anything else change you want. Thanks!

[jeremyfelt]

Thanks for the patches @vishalkakadiya and thanks for the ticket @rmccue and @petya! Based on the direction #35658 is going, there's a chance we won't be using error messages at all. That will need to be resolved first before we tackle this one. :)

[ocean90]

#37401 was marked as a duplicate.

[jeremyfelt]

These error messages were removed completely in [38095].