Opened 8 years ago
Closed 8 years ago
#37345 closed defect (bug) (invalid)
register_meta has unclear error messages
Reported by: | rmccue | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 4.6 |
Component: | Options, Meta APIs | Keywords: | needs-patch dev-feedback |
Focuses: | Cc: |
Description
Added in #35658.
Working through translations with @petya, the error messages we added are hard to translate and unclear in English as well. These should be clarified for both English users and to ease translation. The different errors should have different codes as well.
Attachments (3)
Change History (12)
#3
@
8 years ago
Rather than WP_Errors, these should probably also be _doing_it_wrong
errors, as they're compile-time, not runtime. Right now, it's easy to ignore the returned value too. I'd be happy with a _doing_it_wrong(...); return false;
This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.
8 years ago
@
8 years ago
@@rmccue I think "37345.patch" will work for you. Let me know if anything else change you want.
#6
@
8 years ago
@rmccue
Sorry ignore previous comment and I think "37345_2.patch" will work for you. Let me know if anything else change you want. Thanks!
Just to clarify, we were looking at these strings:
Detailed translator comments for these strings can also help non-developer translators understand and localize them better.