WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#37363 closed defect (bug) (fixed)

Instance query argument breaks YouTube URL parsing in MediaElement.js

Reported by: ocean90 Owned by: ocean90
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Media Keywords: upstream
Focuses: Cc:
PR Number:

Description

See ticket:36759:8:

Works: [video src="https://youtu.be/mhnuES3Zgr4"]
Broken: [video src="https://www.youtube.com/watch?v=mhnuES3Zgr4"]

That's because wp_video_shortcode() appends an instance argument to the original URL, which results in http://www.youtube.com/watch?v=mhnuES3Zgr4&_=2.
This extra query argument breaks this line in MediaElement.js.

I'm going to report this upstream as well.

Change History (3)

#1 in reply to: ↑ description @ocean90
3 years ago

I'm going to report this upstream as well.

Pull request: https://github.com/johndyer/mediaelement/pull/1774

#2 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 38088:

External Libraries: Update MediaElement.js to 2.22.0.

Includes a fix for broken YouTube embeds which are embedded with the [video] shortcode.

Changelog: https://github.com/johndyer/mediaelement/blob/2.22.0/changelog.md
Diff: https://github.com/johndyer/mediaelement/compare/2.21.1...2.22.0

Fixes #37363.

#3 @ocean90
3 years ago

  • Keywords needs-patch removed
  • Milestone changed from Awaiting Review to 4.6
Note: See TracTickets for help on using tickets.