WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#37551 closed enhancement (fixed)

Remove 512 bytes padding for older IE versions

Reported by: rfair404 Owned by: peterwilsoncc
Milestone: 4.9 Priority: normal
Severity: trivial Version: 2.9
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

The solution to #11289 and #8942 has bugged me for a long time. reading up it looks like these changes are to support browsers circa IE5. is it safe to revert these changes (read: remove) at this time?

Attachments (2)

rm-ie5-support-reverts-11289-and-8942.11289.diff (1.2 KB) - added by rfair404 4 years ago.
revert #11289
remove-ie5-support-from-login-page.37551.diff (1.2 KB) - added by rfair404 4 years ago.
more relevant / accurate patch filename

Download all attachments as: .zip

Change History (13)

#1 @rfair404
4 years ago

  • Keywords 2nd-opinion has-patch added
  • Severity changed from normal to trivial
  • Type changed from defect (bug) to enhancement

@rfair404
4 years ago

more relevant / accurate patch filename

#2 @Clorith
4 years ago

  • Version changed from 4.5.3 to 2.9

I know that IE still ships with the Friendly Error Messages enabled by default to this day, but the page in question has evolved a bit since then, and we might be able to drop it as the size of the page has grown.

Of course this means we will have to keep it in mind if changes are ever made to that page though, so I'd personally say there's no harm in leaving the padding there, it prevents us from accidentally breaking something further down the line.

#3 follow-up: @ocean90
4 years ago

  • Summary changed from Is it safe to revert #11289 and #8942 to Remove 512 bytes padding for older IE versions

@rfair404 You can just use the ticket number for patch filenames like 37551.diff.

#4 in reply to: ↑ 3 @rfair404
4 years ago

Replying to ocean90:

@rfair404 You can just use the ticket number for patch filenames like 37551.diff.

Yeah it has been a while since I've submitted one, I'm a little rusty honestly. thanks for the heads up.

#6 @voldemortensen
3 years ago

  • Keywords commit added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 4.9

Support for IE has now been dropped. I see no need for this to be kept going forward.

#7 @SergeyBiryukov
3 years ago

Introduced in [10105], adjusted in [11340] and [12309].

#8 @SergeyBiryukov
3 years ago

Did some testing with IE 11, which is still supported, per Target Browser Coverage post on make/core:

  • As @Clorith noted in comment:2, Friendly HTTP Error Pages are still enabled by default, so if the error page length is less than 512 bytes, IE 11 displays its own page instead of the provided one, same as previous versions.
  • That said, the styles added in [18534] and adjusted in [19297], [19417], [20209] provide enough padding to exceed that threshold, even with gzip compression enabled. Testing error page length for an empty comment with Ticket #11289, IE bug fix padding removed:
    • With gzip disabled: 2442 bytes
    • With gzip enabled: 981 bytes

So I think it's safe enough to remove the IE-specific padding.

#9 @voldemortensen
3 years ago

Did some testing with IE 11, which is still supported, per Target Browser Coverage post on make/core:

Ah, my bad. I thought IE 11 was included on the chopping block.

#10 @peterwilsoncc
3 years ago

  • Component changed from Login and Registration to General

Switching to general as the same function is used for DB and a variety of other errors.

#11 @peterwilsoncc
3 years ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 41369:

General: Remove error screen padding for Internet Explorer.

The inline styles added to the wp_die() handler since [18534] increase file size of the error screen enough to prevent Internet Explorer from displaying a generic error page.

Props rfair404.
Fixes #37551.

Note: See TracTickets for help on using tickets.