WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 months ago

#37848 new enhancement

Form fields misaligned on export.php

Reported by: adhun Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.2.1
Component: Export Keywords: has-patch needs-refresh has-screenshots
Focuses: ui, administration Cc:

Description

On the export page, all the form fields are misaligned.
Refer attached screenshots for a better view.

Attachments (4)

Before-patch.png (56.1 KB) - added by adhun 3 years ago.
Current export screen
After patch.png (63.3 KB) - added by adhun 3 years ago.
After Patch
patch.diff (8.2 KB) - added by adhun 3 years ago.
Patch
37848.2.diff (876 bytes) - added by sarath.ar 3 months ago.
Patch

Download all attachments as: .zip

Change History (11)

@adhun
3 years ago

Current export screen

@adhun
3 years ago

After Patch

@adhun
3 years ago

Patch

#1 @swissspidy
3 years ago

  • Component changed from Administration to Export
  • Focuses template removed
  • Keywords has-patch needs-refresh has-screenshots added
  • Version trunk deleted

Hey there,

Thanks for opening this ticket and contributing a patch.

As you've added the accessibility focus, I had a quick look at the patch in that regard. The patch removes the <label>s in a few places, in some other places the labels are missing the for attribute. This needs to be fixed.

There's a great handbook entry for accessible HTML: https://make.wordpress.org/accessibility/handbook/quick-start-guide/#forms

#2 @afercia
3 years ago

I'd recommend to avoid to use a layout table just for the sake of a slightly better visual alignment. There are also a couple of long standing tickets related to accessibility improvements for the settings pages and forms in the admin, where the proposed goal is to remove the layout tables, see #16413 and #18801. Unfortunately there hasn't been so much movement on those tickets, but in the meanwhile it would be better to don't introduce new layout tables.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 years ago

#4 @afercia
3 years ago

  • Focuses accessibility removed

Going to remove the accessibility focus to get this ticket out from the a11y report but will keep following. Thinking any enhancement should be done together with other similar admin screens, see #16413 and #18801 (though the export screen is not exactly a "Settings page").

#5 @Cheffheid
3 years ago

  • Type changed from defect (bug) to enhancement

#6 @desrosj
4 months ago

@adhun are you able to refresh the patch for this one?

@sarath.ar
3 months ago

Patch

#7 @adhun
2 months ago

  • Version set to 5.2.1

@desrosj i tested @sarathar's patch and it looks fine for me.

Note: See TracTickets for help on using tickets.