Form fields misaligned on export.php

[adhun]

On the export page, all the form fields are misaligned.
Refer attached screenshots for a better view.

[adhun]

Current export screen

[adhun]

After Patch

[adhun]

Patch

[swissspidy]

Hey there,

Thanks for opening this ticket and contributing a patch.

As you've added the accessibility focus, I had a quick look at the patch in that regard. The patch removes the <label>s in a few places, in some other places the labels are missing the for attribute. This needs to be fixed.

There's a great handbook entry for accessible HTML: ​https://make.wordpress.org/accessibility/handbook/quick-start-guide/#forms

[afercia]

I'd recommend to avoid to use a layout table just for the sake of a slightly better visual alignment. There are also a couple of long standing tickets related to accessibility improvements for the settings pages and forms in the admin, where the proposed goal is to remove the layout tables, see #16413 and #18801. Unfortunately there hasn't been so much movement on those tickets, but in the meanwhile it would be better to don't introduce new layout tables.

[afercia]

Going to remove the accessibility focus to get this ticket out from the a11y report but will keep following. Thinking any enhancement should be done together with other similar admin screens, see #16413 and #18801 (though the export screen is not exactly a "Settings page").

[desrosj]

@adhun are you able to refresh the patch for this one?

[sarath.ar]

Patch

[adhun]

@desrosj i tested @sarathar's patch and it looks fine for me.