WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

#37939 closed defect (bug) (fixed)

Incorrect references to plugins API in themes_api() inline docs

Reported by: celloexpressions Owned by: hideokamoto
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Themes Keywords: good-first-bug has-patch
Focuses: docs Cc:

Description

The inline documentation for themes_api() (in wp-admin/includes/theme.php) contains a couple of references to plugins in the $args parameter description that should reference themes. There is a correct reference to plugins filtering the API further up in the documentation.

Attachments (1)

37939.patch (938 bytes) - added by hideokamoto 6 months ago.
fix themes_api description plugin -> themes

Download all attachments as: .zip

Change History (7)

#1 @celloexpressions
7 months ago

  • Focuses docs added

#2 follow-up: @hideokamoto
6 months ago

You mean this line's document is incorrect?
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/theme.php#L335

The second filter, ‘themes_api’, allows a plugin to override the WordPress.org Theme API entirely.

thanks!

#3 in reply to: ↑ 2 ; follow-up: @SergeyBiryukov
6 months ago

Replying to hideokamoto:

You mean this line's document is incorrect?

Nope, it's about these two lines: tags/4.6.1/src/wp-admin/includes/theme.php?marks=363,365#L362

@hideokamoto
6 months ago

fix themes_api description plugin -> themes

#4 in reply to: ↑ 3 @hideokamoto
6 months ago

Replying to SergeyBiryukov:

Nope, it's about these two lines: tags/4.6.1/src/wp-admin/includes/theme.php?marks=363,365#L362

Thanks for your kindness!
I made a patch file :)
https://core.trac.wordpress.org/attachment/ticket/37939/37939.patch

#5 @SergeyBiryukov
6 months ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 4.7
  • Owner set to hideokamoto
  • Status changed from new to assigned

Assigning to mark the good-first-bug as "claimed".

#6 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38623:

Docs: Correct two references to plugins in the $args parameter description for themes_api().

Props hideokamoto.
Fixes #37939.

Note: See TracTickets for help on using tickets.