WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 6 months ago

#38084 new defect (bug)

Fix Inconsistency Theme and Plugin Update Process When No Package Found

Reported by: turtlepod Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version: 4.6.1
Component: Upgrade/Install Keywords: needs-patch
Focuses: ui, administration Cc:
PR Number:

Description

This patch is to solve inconsistency when update package is not available for theme and plugin.

"Updata package not available" happen when there's an update data, but the package (ZIP URL) data is not available in that data.

This is the notice that update is available but package/zip url to update not available (this is the correct way):

Plugin Screen ( wp-admin/plugins.php ):
https://dl.dropboxusercontent.com/u/32880842/etc6/plugin-update-package-na.png

Theme Modal in Theme Screen ( wp-admin/themes.php?theme={theme-name} ) :
https://dl.dropboxusercontent.com/u/32880842/etc6/theme-update-package-na-modal.png

However, WP still show update action link in:

1) Theme Screen ( themes.php ):
https://dl.dropboxusercontent.com/u/32880842/etc6/theme-update-package-na-link.png

Which result to this if user click it:
https://dl.dropboxusercontent.com/u/32880842/etc6/theme-update-package-na-error.png

2) Update Screen ( wp-admin/update-core.php ):
Still show the update checkboxes
https://dl.dropboxusercontent.com/u/32880842/etc6/update-code-checkbox-no-package.png

Which will result to this when user try to update it:

Plugin:
https://dl.dropboxusercontent.com/u/32880842/etc6/bulk-update-plugin-no-package-error.png

Theme:
https://dl.dropboxusercontent.com/u/32880842/etc6/bulk-update-theme-no-package-error.png

And i think that this error is unnecessary.

Effected Files:
1) wp-admin/themes.php
2) wp-admin/includes/theme.php
3) wp-admin/css/common.css (I didn't change minified version)
4) wp-admin/update-core.php

Patch Results:
1) Remove checkboxes of theme and plugin with no update package:
https://dl.dropboxusercontent.com/u/32880842/etc6/update-core-no-package-no-checkbox.png

2) Remove update link (actually button) on themes screen if package not available:
https://dl.dropboxusercontent.com/u/32880842/etc6/themes-screen-no-package-no-button.png

Attachments (1)

38084.patch (6.3 KB) - added by turtlepod 3 years ago.

Download all attachments as: .zip

Change History (5)

@turtlepod
3 years ago

#1 @desrosj
6 months ago

  • Keywords close reporter-feedback added

Hi @turtlepod,

Do the inconsistencies still exist in the latest version of WordPress? Unfortunately, it's impossible to investigate because the screenshots provided in the ticket description are all now returning 404 errors.

In the future, please upload the screenshots directly to the ticket in Trac. This ensures they are maintained indefinitely.

I am going to mark this as a close candidate pending reporter feedback.

#2 @turtlepod
6 months ago

@desrosj
Sorry, dropbox disable direct link to files. (Sorry, I can't really remember if this issue still valid/already fixed)

Here's the working screenshot link:

Plugin Screen ( wp-admin/plugins.php ):
https://www.dropbox.com/s/wrzk7p0xkbhkt6u/plugin-update-package-na.png?dl=0

Theme Modal in Theme Screen ( wp-admin/themes.php?theme={theme-name} ) :
https://www.dropbox.com/s/wiaswkk3zi3be0y/theme-update-package-na-modal.png?dl=0

However, WP still show update action link in:

1) Theme Screen ( themes.php ):
https://www.dropbox.com/s/5avplh9a8r5ir6k/theme-update-package-na-link.png?dl=0

Which result to this if user click it:
https://www.dropbox.com/s/7gv2q5bdoan2tfw/theme-update-package-na-error.png?dl=0

2) Update Screen ( wp-admin/update-core.php ):
Still show the update checkboxes
https://www.dropbox.com/s/cfi6rhieiu2kyav/update-core-no-package-no-checkbox.png?dl=0

Which will result to this when user try to update it:
Plugin:
https://www.dropbox.com/s/uulzcnn60v7dm9i/bulk-update-plugin-no-package-error.png?dl=0
Theme:
https://www.dropbox.com/s/539nhb5avs8mw9f/bulk-update-theme-no-package-error.png?dl=0

Patch Results:
1) Remove checkboxes of theme and plugin with no update package:
https://www.dropbox.com/s/cfi6rhieiu2kyav/update-core-no-package-no-checkbox.png?dl=0
2) Remove update link (actually button) on themes screen if package not available:
https://www.dropbox.com/s/umd3cobm6jh7ltf/themes-screen-no-package-no-button.png?dl=0

Let me know if you have any question.

Last edited 6 months ago by turtlepod (previous) (diff)

#3 @desrosj
6 months ago

  • Keywords needs-patch added; close reporter-feedback removed
  • Severity changed from normal to minor

Thank you for getting back so quickly, @turtlepod.

I've confirmed that this is still present. Update links are displayed even when the user is not able to perform the update.

#4 @turtlepod
6 months ago

@desrosj I added patch (3 years ago)
(you can check the attachment)

is it not working? do you need new one?

Note: See TracTickets for help on using tickets.