WordPress.org

Make WordPress Core

Opened 15 months ago

#38084 new defect (bug)

Fix Inconsistency Theme and Plugin Update Process When No Package Found

Reported by: turtlepod Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.6.1
Component: Upgrade/Install Keywords:
Focuses: ui, administration Cc:

Description

This patch is to solve inconsistency when update package is not available for theme and plugin.

"Updata package not available" happen when there's an update data, but the package (ZIP URL) data is not available in that data.

This is the notice that update is available but package/zip url to update not available (this is the correct way):

Plugin Screen ( wp-admin/plugins.php ):
https://dl.dropboxusercontent.com/u/32880842/etc6/plugin-update-package-na.png

Theme Modal in Theme Screen ( wp-admin/themes.php?theme={theme-name} ) :
https://dl.dropboxusercontent.com/u/32880842/etc6/theme-update-package-na-modal.png

However, WP still show update action link in:

1) Theme Screen ( themes.php ):
https://dl.dropboxusercontent.com/u/32880842/etc6/theme-update-package-na-link.png

Which result to this if user click it:
https://dl.dropboxusercontent.com/u/32880842/etc6/theme-update-package-na-error.png

2) Update Screen ( wp-admin/update-core.php ):
Still show the update checkboxes
https://dl.dropboxusercontent.com/u/32880842/etc6/update-code-checkbox-no-package.png

Which will result to this when user try to update it:

Plugin:
https://dl.dropboxusercontent.com/u/32880842/etc6/bulk-update-plugin-no-package-error.png

Theme:
https://dl.dropboxusercontent.com/u/32880842/etc6/bulk-update-theme-no-package-error.png

And i think that this error is unnecessary.

Effected Files:
1) wp-admin/themes.php
2) wp-admin/includes/theme.php
3) wp-admin/css/common.css (I didn't change minified version)
4) wp-admin/update-core.php

Patch Results:
1) Remove checkboxes of theme and plugin with no update package:
https://dl.dropboxusercontent.com/u/32880842/etc6/update-core-no-package-no-checkbox.png

2) Remove update link (actually button) on themes screen if package not available:
https://dl.dropboxusercontent.com/u/32880842/etc6/themes-screen-no-package-no-button.png

Attachments (1)

38084.patch (6.3 KB) - added by turtlepod 15 months ago.

Download all attachments as: .zip

Change History (1)

@turtlepod
15 months ago

Note: See TracTickets for help on using tickets.