WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#38145 closed defect (bug) (fixed)

Remove target="_blank" from help tab in several Admin screens

Reported by: rianrietveld Owned by: afercia
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: General Keywords: has-patch target-blank
Focuses: accessibility, administration Cc:
PR Number:

Description (last modified by rianrietveld)

Patch removes target="_blank" from links in the help tabs in the Admin in:

  • wp-admin/edit-comments.php
  • wp-admin/edit-form-advanced.php
  • wp-admin/edit-link-form.php
  • wp-admin/edit-tags.php
  • wp-admin/edit.php
  • wp-admin/export.php
  • wp-admin/import.php
  • wp-admin/index.php
  • wp-admin/link-manager.php
  • wp-admin/media-new.php
  • wp-admin/media.php
  • wp-admin/nav-menus.php

I did not remove target="_blank" on links to Preview page/post in edit-form.advanced.php
Tracking ticket with info and discussion: #23432

Attachments (2)

38145.patch (14.4 KB) - added by rianrietveld 3 years ago.
38145.diff (13.6 KB) - added by afercia 3 years ago.

Download all attachments as: .zip

Change History (10)

@rianrietveld
3 years ago

#1 @afercia
3 years ago

  • Keywords target-blank added

#2 @rianrietveld
3 years ago

  • Description modified (diff)

#3 @afercia
3 years ago

Worth noting this patches also edit-comments.php which is already patched in #38140.

#4 @rianrietveld
3 years ago

  • Description modified (diff)

#5 @afercia
3 years ago

  • Keywords needs-refresh added

Needs a refresh.

#6 @afercia
3 years ago

  • Summary changed from Remove target="_blank" from help tab in serveral Admin screens to Remove target="_blank" from help tab in several Admin screens

@afercia
3 years ago

#7 @afercia
3 years ago

  • Keywords needs-refresh removed

Refreshed patch. Removes also a trailing space in a doc block.

#8 @afercia
3 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 38725:

Accessibility: Remove target=_blank from the help tab links on several admin screens.

Stop taking control of users' browsers.

Props rianrietveld.
Fixes #38145. See #23432.

Note: See TracTickets for help on using tickets.