Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#38151 closed defect (bug) (fixed)

die() instead of wp_die() ?

Reported by: imath Owned by: jeremyfelt
Priority: normal Milestone: 4.7
Component: Users Version: 3.1
Severity: normal Keywords: has-patch commit
Cc: Focuses: administration, multisite

Description

After searching in all files, it's the only place die() is used instead of wp_die(), so maybe it should be changed.

Attachments (1)

38151.patch (537 bytes ) - added by imath 10 years ago.

Download all attachments as: .zip

Change History (8)

@imath
10 years ago

#1 @imath
10 years ago

  • Keywords has-patch added

#2 @ocean90
10 years ago

  • Component AdministrationUsers
  • Milestone Awaiting Review4.7
  • Version trunk3.1

Introduced in [16560].

#3 @johnjamesjacoby
10 years ago

  • Keywords commit added
  • Owner set to jeremyfelt
  • Status newassigned

Patch looks good to me.

Also, 6 years… 👍

#4 @jeremyfelt
10 years ago

  • Resolutionfixed
  • Status assignedclosed

Commit [38656] missed the ticket because I missed the #:

Multisite: Replace die() with wp_die() in site users list table.

wp_die() is available and appropriate when checking capabilities while processing list table actions.

Props imath.

#5 @ramiy
10 years ago

@jeremyfelt Please review ticket #34521, and update the text to: Sorry, you are not allowed to remove users.

#6 @jeremyfelt
10 years ago

Thanks @ramiy, can you create a new ticket for that? It looks like there are a couple instances in site-users.php that could be changed.

#7 @ramiy
10 years ago

@jeremyfelt New ticket at #38178.

Note: See TracTickets for help on using tickets.