Replace get_blog_details() usage in wp-includes/ms-blogs.php with get_site()

[iamfriendly]

See https://core.trac.wordpress.org/ticket/37102

[iamfriendly]

get_blogaddress_by_id(), refresh_blog_details(), update_blog_details(), get_blog_status() numbers 13-16 from https://core.trac.wordpress.org/ticket/37102#comment:17

[flixos90]

38351.diff​ replaces get_blog_details() calls in refresh_blog_details(), update_blog_details() and get_blog_status().

I didn't replace it for get_blogaddress_by_id() yet since the $get_all parameter is true there. I can see us do one of two things here:

• either replace it anyway and rely on stating in the dev-note that the site_details filter must be used instead of the blog_details filter
• or not replace it at this point, but do it at the same time we deprecate get_blog_details()

What do you think?

[flixos90]

38351.2.diff​ includes the additional replacement.

I personally think we're fine replacing get_blog_details() regardless of the parameters and document it the filter change. We could theoretically also add an apply_filters_deprecated( 'blog_details', array( $details ), '4.7.0', 'site_details' ) into the relevant part of WP_Site to give developers time to migrate.

[jeremyfelt]

In 38915:

Multisite: Replace get_blog_details() in wp-includes/ms-blogs.php with get_site().

Props flixos90.
See #37102.
Fixes #38351.