Opened 10 years ago
Closed 10 years ago
#38377 closed defect (bug) (fixed)
Empty favicons cause extra HTTP requests to customizer when history.replaceState() used
| Reported by: | westonruter | Owned by: | westonruter |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.7 |
| Component: | Customize | Version: | 4.3 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
In Chrome, at least, when sing history.replaceState() an HTTP request to fetch the favicon is made, of some reason. When there is no site icon specified in WP, then wp_site_icon() outputs the link tags but with empty href. Since an empty href resolves to the current URL, this means in the customizer every time history.replaceState() is called an HTTP request is made back to fetch customize.php over and over again. This will slam the server in the case of #28536 where replaceState is used to update the URL to match the previewed URL and the focused panel/section/control.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
https://github.com/xwp/wordpress-develop/pull/183