WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38385 closed defect (bug) (duplicate)

Twenty Seventeen: Edit link isn't visible in dark theme

Reported by: ocean90's profile ocean90 Owned by:
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: good-first-bug has-patch
Focuses: Cc:

Description

https://cloud.githubusercontent.com/assets/617637/19518666/a880f0b4-9608-11e6-9f46-274b5cea563a.png

This was introduced in ​https://github.com/WordPress/twentyseventeen/pull/469

Attachments (1)

edit-link-fix.38385.diff​ (410 bytes) - added by mohanberry 8 years ago.
Dark theme edit link issue fixed

Download all attachments as: .zip

Change History (5)

#1 @ocean90
8 years ago

  • Keywords good-first-bug added

@mohanberry
8 years ago

Dark theme edit link issue fixed

#2 @mohanberry
8 years ago

  • Keywords has-patch added; needs-patch removed

#3 @karmatosed
8 years ago

@mohanberry unfortunately the patch isn't working on the latest version. This could be potentially because of color changes. @davidakennedy would those impact this patch? I ask as I think we may need to make other adjustments to get this work.

#4 @davidakennedy
8 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

Thank you @mohanberry for the patch! But I'm going to close this ticket in favor of #38389. It's more in-depth and covers more of the issues with the out-of-sync colors. Please contribute there if you'd like.

Note: See TracTickets for help on using tickets.