Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 10 years ago

Closed 10 years ago

#38385 closed defect (bug) (duplicate)

Twenty Seventeen: Edit link isn't visible in dark theme

Reported by:	ocean90	Owned by:
Priority:	normal	Milestone:	4.7
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	good-first-bug has-patch
Cc:		Focuses:

Description

This was introduced in https://github.com/WordPress/twentyseventeen/pull/469

Attachments (1)

edit-link-fix.38385.diff (410 bytes ) - added by mohanberry 10 years ago.: Dark theme edit link issue fixed

Download all attachments as: .zip

Change History (5)

#1 @ocean90
10 years ago

Keywords good-first-bug added

@mohanberry
10 years ago

Attachment edit-link-fix.38385.diff added

Dark theme edit link issue fixed

#2 @mohanberry
10 years ago

Keywords has-patch added; needs-patch removed

#3 @karmatosed
10 years ago

@mohanberry unfortunately the patch isn't working on the latest version. This could be potentially because of color changes. @davidakennedy would those impact this patch? I ask as I think we may need to make other adjustments to get this work.

#4 @davidakennedy
10 years ago

Resolution → duplicate
Status new → closed

Thank you @mohanberry for the patch! But I'm going to close this ticket in favor of #38389. It's more in-depth and covers more of the issues with the out-of-sync colors. Please contribute there if you'd like.

Note: See TracTickets for help on using tickets.

Download in other formats: