New user form on network site has non-required fields that have to be filled in

[jackreichert]

Similar to ticket #37331 In multi-site's New User form, there are several fields that are not required to submit the form (required and aria-required attributes are not set) but the form will fail server-side validation if these fields are not filled in.

[jackreichert]

patch to fix ticket

[jackreichert]

Since I was working on [37331] I thought I should take the liberty to fix this form as well.

[jackreichert]

Per discussion on #37331, patch updated.

[flixos90]

@afercia We just looked at this again during our multisite ticket-scrub. Are there any updates yet from the a11y team on how to deal with required fields in the admin?

[afercia]

@flixos90 I'm afraid we haven't came to a conclusion about the best pattern to use for required fields.

[sabernhardt]

updated with new functions

[sabernhardt]

form with patch

[audrasjb]

Self-assigning for review/test.

[audrasjb]

Thanks for the patch, it looks great to me 👍

[audrasjb]

In 55026:

Networks and Sites: Mark required fields as such in New User Form.

This changeset adds required="required" attributes to required form fields and uses wp_required_field_message() and wp_required_field_indicator() functions to improve the generated markup, and for better consistency with other required fields.

Props jackreichert, flixos90, afercia, sabernhardt.
Fixes #38460.

[johnbillion]

[55026] broke this form. The email input field now has the wrong id and name attributes, so attempting to create a new user from the Network Admin -> Users -> Add New screen results in the following error:

Usernames can only contain lowercase letters (a-z) and numbers.
Please enter a valid email address.

Discovered while testing #57164.

Trac ticket: https://core.trac.wordpress.org/ticket/38460

[audrasjb]

In 55394:

Networks and Sites: Fix the attributes for the email input field on the new network user screen.

This reverts the email input field back to its previous state (before [55026]), except for the expected addition of the required attribute.

Follow-up to [55026].

Props johnbillion.
Fixes #38460.

committed in https://core.trac.wordpress.org/changeset/55394