Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#38554 closed defect (bug) (fixed)

Customizer: unexpected icon behaviour

Reported by: karmatosed's profile karmatosed Owned by: sirbrillig's profile sirbrillig
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch
Focuses: Cc:


I loaded up Twenty Seventeen and only see the icons on mobile view by clicking 'menu'. Not sure this is expected things then look a little weird. See here:

Attachments (1)

38554.0.diff (901 bytes) - added by westonruter 7 years ago.

Download all attachments as: .zip

Change History (8)

#1 @westonruter
7 years ago

  • Milestone changed from Awaiting Review to 4.7
  • Owner set to sirbrillig
  • Status changed from new to assigned

#2 @westonruter
7 years ago

  • Component changed from General to Customize

#3 @karmatosed
7 years ago

  • Summary changed from Customizer: icons only show on mobile menu to Customizer: unexpected icon behaviour

I'm going to change the title as on doing more tests some interesting things came up that I think go beyond this. Here is the video with mouse clicks to see:

Things that feel weird:

  • The icons seem off the page a number of times
  • There seems some odd show/hide linking to the mobile menu

7 years ago

#4 @westonruter
7 years ago

  • Keywords has-patch added

@karmatosed 38554.0.diff should fix the issue with the shortcuts toggling unexpectedly. The click handler was not considering clicks on elements nested inside of buttons, so clicks on the nested SVG element was incorrectly causing the shortcuts to toggle. Please give that a try. This should at least fix the second issue you identified (“There seems some odd show/hide linking to the mobile menu”). The other issue (“The icons seem off the page a number of times”) may be getting addressed in #38532, but maybe not.

#5 @celloexpressions
7 years ago

Icons being positioned off screen is something that individual themes will need to adjust on an icon-by-icon basis probably. Core currently tries to balance keeping them at least partially visible without overlapping the content that they edit.

#6 @karmatosed
7 years ago

@westonruter that is much better thanks. I still have the icons off the screen but they do this at different resolutions. Is this something that the theme should still fix then @celloexpressions? See here:

#7 @westonruter
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 39018:

Customize: Prevent toggling edit shortcuts when doing shift-click or when clicking on a descendent of an interactive element.

See #38532, #27403.
Fixes #38554.

Note: See TracTickets for help on using tickets.