Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#38791 closed defect (bug) (fixed)

REST API: Strings with placeholders are missing translators comments

Reported by: dimadin's profile dimadin Owned by: rmccue's profile rmccue
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: I18N Keywords: has-patch
Focuses: rest-api Cc:


There are new strings with a placeholder but that lack translators comment. In the patch I marked those that I saw.

Attachments (1)

38791.1.diff (8.2 KB) - added by dimadin 7 years ago.

Download all attachments as: .zip

Change History (10)

7 years ago

#1 @rmccue
7 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.7
  • Owner set to rmccue
  • Status changed from new to reviewing

#2 @rmccue
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 39238:

REST API: Add translator comments to text with placeholders.

Props dimadin.
Fixes #38791.

#3 @rmccue
7 years ago

In 39239:

REST API: Move translator comments to preceding line.

Inline translator comments break POT file generation.

Props dd32.
See #38791.

#4 @SergeyBiryukov
7 years ago

In 39245:

REST API: After [39238] and [39239], move the remaining translator comments to preceding line.

See #38791.

#5 @ramiy
7 years ago

The messages should comply the rules in #34521.

#6 @SergeyBiryukov
7 years ago

In 39251:

REST API: Unify permission error messages.

Props ramiy.
See #38791, #34521.

#7 @SergeyBiryukov
7 years ago

In 39252:

REST API: Remove two duplicate strings, use the ones we already have.

See #38791.

#8 @SergeyBiryukov
7 years ago

In 39264:

REST API: Uppercase 'ID' in endpoint descriptions and error messages for consistency with other strings.

See #38791.

#9 @SergeyBiryukov
7 years ago

In 39266:

REST API: After [39252] and [39264], uppercase some more 'ID' references in translatable strings.

See #38791.

Note: See TracTickets for help on using tickets.