WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#38871 closed defect (bug) (fixed)

Rename 'show_site_locale_default' to 'show_option_site_default'

Reported by: SergeyBiryukov Owned by: ocean90
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

[39169] introduced a show_site_locale_default argument for wp_dropdown_languages(), which adds a 'Site Default' option to the user-specific language setting.

I'm not a native English speaker, but the wording of the argument name sounds confusing to me.

Any chance to rename it to show_option_site_default, for consistency with show_option_all and show_option_none arguments in wp_dropdown_categories()?

Attachments (1)

38871.patch (2.2 KB) - added by SergeyBiryukov 5 months ago.

Download all attachments as: .zip

Change History (6)

#2 @swissspidy
5 months ago

Makes sense to me, thanks for pointing this out!

#5 @ocean90
5 months ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 39331:

I18N: In wp_dropdown_languages() rename the new show_site_locale_default argument to show_option_site_default.

This makes it consistent with arguments of other wp_dropdown_*() functions.

Props SergeyBiryukov.
See #38632.
Fixes #38871.

Note: See TracTickets for help on using tickets.