WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#39016 closed defect (bug) (fixed)

Merge two similar "date" strings in the REST API

Reported by: ramiy's profile ramiy Owned by: rachelbaker's profile rachelbaker
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: REST API Keywords: has-patch commit dev-reviewed
Focuses: rest-api Cc:

Description

Few more translation strings to merge.

See the attached files.

Attachments (2)

similar-date-strings.png​ (65.2 KB) - added by ramiy 8 years ago.
39016.patch​ (2.1 KB) - added by ramiy 8 years ago.

Download all attachments as: .zip

Change History (10)

@ramiy
8 years ago

@ramiy
8 years ago

#1 @ramiy
8 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core-i18n by ramiy. ​View the logs.
8 years ago

#3 @swissspidy
8 years ago

  • Keywords commit added

Sounds good to me. Would need a second review for this being considered for 4.7.

As this doesn't introduce new strings, it's not a i18n-change

#4 @helen
8 years ago

  • Milestone changed from Awaiting Review to 4.7

#5 @rachelbaker
8 years ago

  • Keywords dev-reviewed added

39016.patch​ LGTM

#6 @ramiy
8 years ago

This doesn't effect the string-freeze, we don't add new translation strings, we are just merging similar strings.

#7 @rachelbaker
8 years ago

  • Owner set to rachelbaker
  • Resolution set to fixed
  • Status changed from new to closed

In 39488:

REST API: Merge similar date strings in the revisions and comments controllers.

Props ramiy.
Fixes #39016.

#8 @rachelbaker
8 years ago

In 39489:

REST API: Merge similar date strings in the revisions and comments controllers.

Merges [39488] to the 4.7 branch.

Props ramiy.
Fixes #39016 for 4.7.

Note: See TracTickets for help on using tickets.