Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#39081 closed defect (bug) (fixed)

Customize: changeset_uuid query param doesn't get stripped at initial save of starter content

Reported by: westonruter Owned by: westonruter
Priority: normal Milestone: 4.7
Component: Customize Version:
Severity: normal Keywords: has-patch commit dev-reviewed
Cc: Focuses:

Description

A changeset_uuid query parameter is added to the window's location via replaceState after a changeset is created and should remain until it is published. Upon publishing, the parameter should be removed because published changesets are frozen and cannot be opened in the customizer. When a changeset is published, a new changeset UUID is generated and is then supplied the next time changes are made.

When loading up a fresh_site and saving the starter content, the initial publishing is causing the next UUID to be supplied into changeset_uuid query param unexpectedly when it should be left empty.

Attachments (1)

39081.0.diff (596 bytes ) - added by westonruter 10 years ago.

Download all attachments as: .zip

Change History (8)

@westonruter
10 years ago

#1 @westonruter
10 years ago

  • Keywords has-patch needs-testing added

#2 @dlh
10 years ago

39081.0.diff works as expected for me.

#3 @westonruter
10 years ago

  • Keywords commit dev-feedback added; needs-testing removed

#4 @helen
10 years ago

  • Keywords dev-reviewed added; dev-feedback removed

This ticket was mentioned in Slack in #core by helen. View the logs.


10 years ago

#6 @westonruter
10 years ago

  • Owner set to westonruter
  • Resolutionfixed
  • Status newclosed

In 39504:

Customize: Ensure changeset_uuid query param is removed from the customize.php window's location once a changeset has been published (committed) with starter content.

Props westonruter, dlh for testing.
See #30937.
Fixes #39081.

#7 @westonruter
10 years ago

In 39505:

Customize: Ensure changeset_uuid query param is removed from the customize.php window's location once a changeset has been published (committed) with starter content.

Props westonruter, dlh for testing.
Merges [39504] onto 4.7 branch.
Fixes #39081 for 4.7.

Note: See TracTickets for help on using tickets.