WordPress.org

Make WordPress Core

Opened 15 months ago

Last modified 2 weeks ago

#39108 assigned defect (bug)

Media: can't leave an image "untitled" from the "Edit Media" menu

Reported by: dromero20 Owned by: junaidkbr
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.6.1
Component: Media Keywords: good-first-bug has-patch needs-testing
Focuses: Cc:

Description

Just found this issue while testing the Media Library. If you try to remove the image's title from the "Edit Media", it gets "autorenamed" with the original name of the uploaded file. You can't leave that image untitled. But, if you rename the image from the "Attachment Details" menu, you can leave the image untitled perfectly.

I've made a gif of the process, I hope it helps to understand what I'm saying:
http://hgrequests.files.wordpress.com/2016/12/media.gif

Steps to reproduce
-Upload an image.
-Go to Media Library (wp-admin)
-Select Mode:List View and click on the image
-Change the name, Update. Then, remove the name, Update again (the image will be renamed with the file's original name)

Attachments (3)

media.gif (4.9 MB) - added by dromero20 15 months ago.
Gif of the issue
Jan-05-2018 08-41-38.mp4 (6.9 MB) - added by desrosj 7 weeks ago.
Updated demo of the bug
39108.patch (1.2 KB) - added by Junaidkbr 7 weeks ago.

Change History (7)

@dromero20
15 months ago

Gif of the issue

This ticket was mentioned in Slack in #core-media by desrosj. View the logs.


7 weeks ago

#2 @desrosj
7 weeks ago

  • Keywords needs-patch good-first-bug added

Hi @dromero20, and welcome to Trac!

I was able to reproduce this bug. Are you interested in creating a patch for this? For help with that, you can check out the handbook: https://make.wordpress.org/core/handbook/contribute/

@desrosj
7 weeks ago

Updated demo of the bug

@Junaidkbr
7 weeks ago

#3 @Junaidkbr
7 weeks ago

  • Keywords has-patch needs-testing added; needs-patch removed

@desrosj My patch takes care of the issue but I had trouble sending the auto generated title back to the media modal.

My patch has changes in https://core.trac.wordpress.org/browser/tags/4.9/src/wp-admin/includes/ajax-actions.php#L2516 where I am returning wp_send_json_success( $json_data ); with $json_data = array( 'title' => $new_title );. But I have no clue how to get it from the AJAX response at https://core.trac.wordpress.org/browser/tags/4.9/src/wp-includes/js/media-views.js?rev=42198#L6331

#4 @DrewAPicture
2 weeks ago

  • Owner set to junaidkbr
  • Status changed from new to assigned

Assigning to mark the good-first-bug as "claimed".

Note: See TracTickets for help on using tickets.