Translation Update after 4.7 update gives Javascript Error

[garrett-eclipse]

I just updated to WordPress 4.7, which then enabled the update translations button, so did so and it updated the translation no problem;

Update Translations
Updating translations for WordPress (en_CA)…
Translation updated successfully.
Return to WordPress Updates page
But my Debug Bar flagged a JS issue, inspecting the full error is;

update-core.php?action=do-translation-upgrade:428 Uncaught TypeError: Cannot read property 'decrementCount' of undefined

at ​https://bearmountain.ca/wp-admin/update-core.php?action=do-translation-upgrade:428:28
at ​https://bearmountain.ca/wp-admin/update-core.php?action=do-translation-upgrade:431:8

It goes away as soon as you go to another page, but wanted to flag the minor bug.

Original Support Ticket - ​https://wordpress.org/support/topic/translation-update-after-4-7-update-gives-javascript-error/

[swissspidy]

Hi,

Thanks for opening the ticket! This might be caused by a recent improvement to the update counter, see #13071. However, I wasn't able to reproduce this when updating translations on my local install.

Have you already tried clearing your browser's cache and disabling all plugins?

[garrett-eclipse]

Hi @swissspidy

As I didn't want to roll back the live site I tried to install clean 4.6.1 set to en_CA. And the upgrade to 4.7 seemed to automatically do the translation so that wasn't available after the 4.7 upgrade as it was with my other install.

SO I'm going to guess it was a cache or plugin/theme conflict and close this.

Thanks

[swissspidy]

Alright, I'll keep an eye on it nonetheless.

[ocean90]

This could be caused by a race condition when the update of a translation was faster than loading the page and update.js which is now loaded in the footer.

[garrett-eclipse]

Thanks Guys, do you feel I should reopen this for further investigation? Cheers

[Presskopp]

fresh 4.9RC3 installation, first run updating translations

[Presskopp]

Still coming in Version 5.0-alpha-42389:

update-core.php?action=do-translation-upgrade:379 Uncaught TypeError: Cannot read property 'decrementCount' of undefined
    at update-core.php?action=do-translation-upgrade:379
    at update-core.php?action=do-translation-upgrade:382

[swissspidy]

We should be able to fix this race condition by using wp && wp.updates && wp.updates.decrementCount there.

[Presskopp]

@swissspidy Can you please take a look at the patch approach (following your argumentation, no own powers here)

[swissspidy]

In 44513:

Upgrade/Install: Prevent possible JavaScript error when updating translations.

Props Presskopp.
Fixes #39189.

[swissspidy]

Bugfix: #46563