Opened 10 years ago
Closed 10 years ago
#39212 closed enhancement (fixed)
Replace is_super_admin() check with current_user_can( 'manage_network_users' ) in wp-admin/includes/ms.php
| Reported by: | bhargavbhandari90 | Owned by: | flixos90 |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.8 |
| Component: | Role/Capability | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | multisite |
Description
This is part of the #37616 task. There are 1 is_super_admin() checks in wp-admin/includes/ms.php that should be replaced with current_user_can( 'manage_network_users' ).
Attachments (2)
Change History (7)
#1
follow-up:
↓ 2
@
10 years ago
- Focuses multisite added
- Keywords has-patch needs-refresh added
- Milestone Awaiting Review → 4.8
- Owner set to
- Status new → reviewing
#2
in reply to: ↑ 1
@
10 years ago
Replying to flixos90:
Thanks for the patch @bhargavbhandari90! It looks good so far, there are only two small adjustments that should be made, which are both related to coding standards:
- insert a space between the
!andcurrent_user_can( 'manage_network_users' )- add curly braces around the clause (this is an acceptable change since we are adjusting that code anyway)
Thanks for the update. I have created another patch.
#3
follow-up:
↓ 4
@
10 years ago
- Keywords needs-refresh removed
Great, thanks a lot @bhargavbhandari90 - looks good! :)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Thanks for the patch @bhargavbhandari90! It looks good so far, there are only two small adjustments that should be made, which are both related to coding standards:
!andcurrent_user_can( 'manage_network_users' )