Opened 8 years ago
Closed 8 years ago
#39212 closed enhancement (fixed)
Replace is_super_admin() check with current_user_can( 'manage_network_users' ) in wp-admin/includes/ms.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Role/Capability | Keywords: | has-patch |
Focuses: | multisite | Cc: |
Description
This is part of the #37616 task. There are 1 is_super_admin() checks in wp-admin/includes/ms.php that should be replaced with current_user_can( 'manage_network_users' ).
Attachments (2)
Change History (7)
#1
follow-up:
↓ 2
@
8 years ago
- Focuses multisite added
- Keywords has-patch needs-refresh added
- Milestone changed from Awaiting Review to 4.8
- Owner set to flixos90
- Status changed from new to reviewing
#2
in reply to:
↑ 1
@
8 years ago
Replying to flixos90:
Thanks for the patch @bhargavbhandari90! It looks good so far, there are only two small adjustments that should be made, which are both related to coding standards:
- insert a space between the
!
andcurrent_user_can( 'manage_network_users' )
- add curly braces around the clause (this is an acceptable change since we are adjusting that code anyway)
Thanks for the update. I have created another patch.
#3
follow-up:
↓ 4
@
8 years ago
- Keywords needs-refresh removed
Great, thanks a lot @bhargavbhandari90 - looks good! :)
Note: See
TracTickets for help on using
tickets.
Thanks for the patch @bhargavbhandari90! It looks good so far, there are only two small adjustments that should be made, which are both related to coding standards:
!
andcurrent_user_can( 'manage_network_users' )