Add `assertNotFalse` method to `WP_UnitTestCase`.

[peterwilsoncc]

The version of phpunit WP uses on older versions of PHP doesn't include the assertNotFalse method.

[peterwilsoncc]

In 39219.diff​.

I've tested locally that it passes with all falsy values except false. I'm not sure where I should put these.

$this->assertNotFalse( 0 );
$this->assertNotFalse( null );
$this->assertNotFalse( '' );
$this->assertNotFalse( array() );
$this->assertNotFalse( 0.0 );
$this->assertNotFalse( '0' );

[dd32]

@peterwilsoncc Confirmed that the logic matches what is in PHPUnit: ​https://github.com/sebastianbergmann/phpunit/blob/9758eee6421efd997a42fe850f74292a490e9c70/src/Framework/Assert.php#L1185-L1196 so this seems fine.

Is it possible to find the occurrences in the current unit tests where this was to be used, but avoided?

[peterwilsoncc]

Replying to dd32:

Is it possible to find the occurrences in the current unit tests where this was to be used, but avoided?

Uploaded in 39219-unit-tests-to-replace.diff​, it replaces assertNotSame( false, $actual ) with assertNotFalse( $actual ). There are a few assertNotEquals() calls that look like they could be replaced but I'd prefer to be conservative.

I've kept the tests seperate, do you think they can be committed as part of this ticket or should it be a follow up?

[swissspidy]

In addition to assertNotSame() there are a few instances of assertTrue( false === … ) instead of assertFalse() and assertTrue( false !== ) instead of assertNotFalse(). They should be updated as well.

[johnbillion]

There's also some prior usage: https://core.trac.wordpress.org/search?q=assertnotfalse&changeset=on

[SergeyBiryukov]

In 39919:

Build/Test Tools: Add assertNotFalse() method to WP_UnitTestCase and use it where appropriate.

Props peterwilsoncc.
Fixes #39219.

[swissspidy]

In 40388:

Build/Test Tools: Add assertNotFalse() method to WP_UnitTestCase and use it where appropriate.

Props peterwilsoncc.
Fixes #39219.

Merges [39919] to the 4.7 branch.