WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#39398 closed defect (bug) (fixed)

REST API: Remove errant annotation from `test_get_items_pagination_headers`

Reported by: rachelbaker's profile rachelbaker Owned by: rachelbaker's profile rachelbaker
Milestone: 4.8 Priority: normal
Severity: minor Version:
Component: REST API Keywords: good-first-bug has-patch
Focuses: Cc:

Description

Introduced in [38832] the WP_Test_REST_Users_Controller->test_get_items_pagination_headers has an extraneous @group test notation that should be removed.

See https://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/rest-api/rest-users-controller.php#L171

Attachments (3)

39398.diff​ (496 bytes) - added by sanket.parmar 8 years ago.
39398-rest-posts-controller.patch​ (496 bytes) - added by sanket.parmar 8 years ago.
Introduced in [38832] the WP_Test_REST_Posts_Controller->test_get_items_pagination_headers has an extraneous @group test notation that should be removed. See https://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php#L727
39398.1.diff​ (992 bytes) - added by rachelbaker 8 years ago.
combined patch

Download all attachments as: .zip

Change History (8)

@sanket.parmar
8 years ago

#1 @sanket.parmar
8 years ago

  • Keywords has-patch added; needs-patch removed

#2 @rachelbaker
8 years ago

  • Summary changed from REST API: Remove errant annotation from `WP_Test_REST_Users_Controller->test_get_items_pagination_headers` to REST API: Remove errant annotation from `test_get_items_pagination_headers`

#3 @rachelbaker
8 years ago

Looks like this occurs in the WP_Test_REST_Posts_Controller test_get_items_pagination_headers() method as well. See #39409.

Let's use this ticket to remove the annotations from both places. I didn't find any other occurrences in our tests.

@sanket.parmar
8 years ago

Introduced in [38832] the WP_Test_REST_Posts_Controller->test_get_items_pagination_headers has an extraneous @group test notation that should be removed. See https://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php#L727

#4 @rachelbaker
8 years ago

#39409 was marked as a duplicate.

@rachelbaker
8 years ago

combined patch

#5 @rachelbaker
8 years ago

  • Owner set to rachelbaker
  • Resolution set to fixed
  • Status changed from new to closed

In 39643:

REST API: Remove errant annotation from test_get_items_pagination_headers() method.

Removes the debugging group notation left in the WP_Test_REST_Users_Controller and WP_Test_REST_Posts_Controller classes pagination headers method. Introduced in [38832].

Props sanket.parmar.
Fixes #39398.

Note: See TracTickets for help on using tickets.