cannot advance by typing in page number

[taxman10m]

When looking at a users from a group, the pagination does not advance to the correct page in the group if the page number is manually inputted.

To recreate:

Go to the users page.
Click into any group other than All.
Where it says, X of Y pages, change the value of X and hit enter.

The results will be of All, and not of the selected group.

[taxman10m]

screenshot

[kailanitish90]

Hi @taxman10m,

I have attached a patch for above issue.

Thanks

[sagarprajapati]

Patch without extra spaces

[sagarprajapati]

Hi @kailanitish90, @taxman10m

Here no need to add the blank space at the do_action( 'restrict_manage_users', $which );

Thanks

[adamsilverstein]

@kailanitish90 thanks for the patch! how did you figure out you needed to add the hidden role field?

I'll give this a test, it would be good to also get feedback from @taxman10m to verify it fixes the issue for him.

it looks like $_REQUEST['role'] could use some sanitization or escaping on output to prevent XSS

[afercia]

It seems to me something similar happens also in other places. For example, on the posts screen: click on the "Mine" link so posts are filtered by your author ID (e.g. &author=1). Then use the page number input field in the pagination as described above, and the author parameter is lost.
To make testing easier in the various list tables screens, you could set the Screen Options "Number of items per page" to something lower than the default value.

[kailanitish90]

Hi @adamsilverstein, @taxman10m,

I have used hidden field because we can not get any particular role without set it into hidden field. Like in the post, post status post_status=publish .

As per @sagarprajapati patch I think is better to set the hidden field after end-if condition.

Thanks

[SergeyBiryukov]

Related: #39523

[sagarprajapati]

Hi,

I have updated my patch with esc_attr. Please check this patch.

Thanks

[mayurk]

Hi @taxman10m , @kailanitish90 , @sagarprajapati , @swissspidy , @SergeyBiryukov

I have tested 39435.2.patch with the core latest WordPress version and it's working as expected.

Thanks

[SergeyBiryukov]

In 39937:

Users: Preserve role filter in list table after entering a page number in paging input.

Props kailanitish90, sagarprajapati.
Fixes #39435.