WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 8 months ago

#39448 closed enhancement (fixed)

To-do: remove at the end of 2016

Reported by: Presskopp Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 4.8
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

I found some code comment "To-do: remove at the end of 2016"

in script-loader.php (L. 125) & related wp-fullscreen-stub.js

I tried to find out when/why this has been put in, but cannot. I'm sure you know how to deal with this - have fun :)

I was asking @sergey about this, but he seems offline.

Attachments (2)

39448.patch (644 bytes) - added by ketuchetan 4 years ago.
Removed To-do: remove at the end of 2016
39448.2.patch (1.1 KB) - added by ketuchetan 4 years ago.
Removed To-do: remove at the end of 2016

Download all attachments as: .zip

Change History (8)

#1 @dd32
4 years ago

Source: [32677]

We can probably leave it in place honestly, but pinging @azaozz

@ketuchetan
4 years ago

Removed To-do: remove at the end of 2016

#2 @SergeyBiryukov
4 years ago

  • Component changed from General to Editor

#3 @SergeyBiryukov
4 years ago

wp-admin/js/wp-fullscreen-stub.js has the same comment

@ketuchetan
4 years ago

Removed To-do: remove at the end of 2016

#4 @Howdy_McGee
9 months ago

  • Keywords has-patch added

#5 @SergeyBiryukov
9 months ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#6 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47164:

Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.

The original script was deprecated in [30338] and removed in [32677].

Props Presskopp, ketuchetan.
Fixes #39448.

Note: See TracTickets for help on using tickets.