WordPress.org
Get WordPress

Make WordPress Core

Opened 19 years ago

Closed 19 years ago

#3956 closed enhancement (fixed)

Clean up vars.php

Reported by: rob1n's profile rob1n Owned by: rob1n's profile rob1n
Milestone: 2.2 Priority: normal
Severity: normal Version: 2.2
Component: Optimization Keywords: has-patch commit
Focuses: Cc:

Description

vars.php currently:

  • Uses 0/1 for false/true. Mark noted in the source with a comment that "we should probably use true/false." 0 and 1 are a bit confusing.
  • Does preg_match's that really don't need to be regular expressions. strpos() works much faster.

Just some speed ups.

Attachments (1)

3956.diff​ (2.4 KB) - added by rob1n 19 years ago.
Clean up of vars.php.

Download all attachments as: .zip

Change History (4)

@rob1n
19 years ago

Clean up of vars.php.

#1 @rob1n
19 years ago

  • Keywords has-patch added
  • Owner changed from anonymous to rob1n
  • Status changed from new to assigned

#2 @rob1n
19 years ago

  • Keywords commit added

#3 @ryan
19 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [5024]) vars.php cleanups and speedups from rob1n. fixes #3956

Note: See TracTickets for help on using tickets.