WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#39655 closed defect (bug) (fixed)

Menu's last item border remains after all plugins update

Reported by: Junaidkbr Owned by: swissspidy
Milestone: 4.8 Priority: normal
Severity: normal Version: 4.6
Component: Plugins Keywords: has-patch
Focuses: ui Cc:
PR Number:

Description

In Dashboard > Plugins, when all plugins are finished updating, the DOM is modified accordingly. However, the Plugins page's menu's last item remains with a right border while last item on other pages' menu's last item does not have a right border.

https://cldup.com/zkwNM-VRGP.PNG

Attachments (3)

border-after-updates.PNG (70.5 KB) - added by Junaidkbr 3 years ago.
39655.patch (435 bytes) - added by sagarprajapati 3 years ago.
39655.diff (400 bytes) - added by swissspidy 3 years ago.

Download all attachments as: .zip

Change History (10)

#1 @Junaidkbr
3 years ago

  • Summary changed from Menu last item border remains after all plugin updates to Menu's last item border remains after all plugins update

#2 @sagarprajapati
3 years ago

  • Keywords has-patch added

Hi All,

Please check above patch for the solution.

Thanks

This ticket was mentioned in Slack in #core by sagarprajapati. View the logs.


3 years ago

#4 @swissspidy
3 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to swissspidy
  • Status changed from new to reviewing

@swissspidy
3 years ago

#5 @swissspidy
3 years ago

  • Milestone changed from Future Release to 4.8

#6 @swissspidy
3 years ago

  • Version changed from 4.7.1 to 4.6

Patch works as expected. I made only a small adjustment in 39655.diff to use $( this ).children() in the replacement. Feels more readable/clean.

#7 @swissspidy
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 40025:

Plugins: Remove trailing pipe symbol in sub navigation after updating the last plugin.

Props sagarprajapati.
Fixes #39655.

Note: See TracTickets for help on using tickets.