Opened 4 years ago
Last modified 16 months ago
#39684 new enhancement
Improve UI of Activate button in Add plugins page
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | 4.7.1 |
Component: | Plugins | Keywords: | has-patch needs-screenshots close |
Focuses: | ui | Cc: |
Description
Should use button-primary
class for Activate button in Add plugins page (like after installing plugin)
Attachments (1)
Change History (7)
#4
@
4 years ago
IIRC we didn't add the primary class there on purpose because it's not the primary action on that screen. We added it for plugins that are being installed through Shiny Updates (Install -> Installing... -> Installed -> Activate, where Activate will be primary).
Note: See
TracTickets for help on using
tickets.
@truongwp Thanks for opening the ticket and adding a patch.
If several plugins are activated, there might be several buttons with the
button-primary
class applied at once. Do you think this might be an issue for screen readers or visual focus?The primary class is usually added to indicate "this is the primary action on this screen" - I'm not sure that applies to 'Activate'.