WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 4 days ago

#39684 new enhancement

Improve UI of Activate button in Add plugins page

Reported by: truongwp Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.7.1
Component: Plugins Keywords: has-patch needs-screenshots close
Focuses: ui Cc:
PR Number:

Description

Should use button-primary class for Activate button in Add plugins page (like after installing plugin)

Attachments (1)

39684.patch (670 bytes) - added by truongwp 3 years ago.

Download all attachments as: .zip

Change History (7)

@truongwp
3 years ago

#1 @truongwp
3 years ago

  • Keywords has-patch added

#2 @swissspidy
3 years ago

  • Keywords needs-screenshots added

#3 @adamsilverstein
3 years ago

@truongwp Thanks for opening the ticket and adding a patch.

If several plugins are activated, there might be several buttons with the button-primary class applied at once. Do you think this might be an issue for screen readers or visual focus?

The primary class is usually added to indicate "this is the primary action on this screen" - I'm not sure that applies to 'Activate'.

#4 @swissspidy
3 years ago

IIRC we didn't add the primary class there on purpose because it's not the primary action on that screen. We added it for plugins that are being installed through Shiny Updates (Install -> Installing... -> Installed -> Activate, where Activate will be primary).

#5 @truongwp
3 years ago

Thanks for your explanation. I understood. There is a visual focus problem if there are many plugins is installed but not activated.

#6 @Hareesh Pillai
4 days ago

  • Keywords close added

As per the above comments, it is intentionally built this way.
Adding the close keyword.

Note: See TracTickets for help on using tickets.