Twenty Seventeen: Pagination links don't appear for home pages

[dimitris.m]

Steps to reproduce:

• Create a new page and split its content with <!--nextpage-->
• Set this page to be your Home one (under Settings/Reading)
• Visit the page in the front-end

The Pagination links aren't shown at all in the bottom of the page.

This works if the page isn't set for Home and also works with the "TwentySixteen" theme.

[laurelfulford]

Twenty Seventeen - front page editor

[laurelfulford]

Twenty Seventeen - About Page editor

[laurelfulford]

Twenty Seventeen - both the front page and about page content appearing on the front page

[laurelfulford]

Thanks for reporting this, @dimitris.m!

I can recreate this as well, both by trying to add a page break to the front page's content, and trying to add a page break to one of the pages showing on the front page.

This happens with both the classic and block-based editor.

[poena]

Adds wp_link_pages to content-front-page.php

[poena]

Sample page with page break, set as homepage.

[ianbelanger]

Updates patch to work in content-front-page.php and content-front-page-panels.php

[ianbelanger]

I updated the patch so that pagination will work on the homepage and in the homepage panels. Would love to get some feedback from other devs on this one.

[samful]

Looking at themes TwentyNineteen and TwentyTwenty, this is exactly how they handle this, so I don’t see any issues with this patch.

I can also confirm that @poena’s patch fixed the home page and @ianbelanger’s patch improved on this to add the fix to the Front Page Sections (these are the sections used in Customise->Theme Options).

Something interesting I noticed was that, if you have 2 pages on the home page and go to the 2nd page of the homepage, the other pages listed (via Customise->Theme Options) on the home screen will also go to the 2nd page.

For example, I have the "home" page as the WordPress Home page and the "sample page" as the Front page section 1, if I click on page 2 of the page called "home", the "sample page" will go to the 2nd page also (because every page on the homepage will go to page 2). I'm not sure how likely this will be, or what can be done about this, but I thought I'd mention it anyway... I'll add screenshots for clarity.

[ianbelanger]

Reviewing for commit.

[ianbelanger]

In 48064:

Bundled Themes: Twenty Seventeen pagination links don't appear for home pages.

Fixes issues where pagination does not work on the page that is set to the home page.

Props dimitris.m, laurelfulford, poena, ianbelanger, samful.
Fixes #39685.

[ianbelanger]

Reopening for backport.

[desrosj]

With 5.5 just under 5 weeks away, there is no 5.4.3 planned. Moving back to the 5.5 milestone.