Error in pagination classes

[SGr33n]

Hi,
Looking at the code I found a little error on wp-admin/includes/class-wp-list-table.php. The $pagination_links_class variable should add a hide-if-js at line 848, but instead of adding the class at the existing variable it clears the previus class.

[1naveengiri]

@SGr33n This is perfect.
No need to let that class there, if that is not in use.

[SergeyBiryukov]

Introduced in [20094].

[afercia]

The original intent to add the CSS class is pretty clear (because there is a space before the class). So I'd say either the space should be removed or the two strings be concatenated. I'm not sure this code is actually used anywhere in core. The infinite_scroll pagination arg is true just for the themes and theme-install list tables, and they're not used any longer (unless I'm missing something). However, custom tables added by plugins might use infinite scroll.

The pagination-links CSS class shouldn't be removed in any case, because it is used for some styling in the responsive view.

The theme install screen in WordPress 3.8, before the JS refactoring introduced in 3.9:

With JS off:

[afercia]

In 41019:

Administration: in WP_List_Table->pagination(), properly concatenate CSS classes for the pagination links when infinite_scroll is set to true.

Props SGr33n.
See #19815.
Fixes #40003.