Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#40382 closed enhancement (fixed)

"IP address" is not "IP"

Reported by: mako09's profile mako09 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: has-patch needs-testing
Focuses: Cc:

Description

"IP" does not mean "IP address".

Attachments (4)

40382.patch (2.5 KB) - added by mako09 8 years ago.
40382.diff (15.7 KB) - added by gk.loveweb 8 years ago.
Changed "IP" to "IP address".
40382-2.diff (15.7 KB) - added by bradparbs 8 years ago.
Fix incorrect usage of "address's"
40382-3.diff (15.7 KB) - added by bradparbs 8 years ago.
Fix incorrect usage of "address's" (for real this time)

Download all attachments as: .zip

Change History (19)

@mako09
8 years ago

#1 @swissspidy
8 years ago

  • Type changed from defect (bug) to enhancement
  • Version trunk deleted

#2 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 4.8

Seems consistent with #37871.

#3 @Presskopp
8 years ago

  • Keywords has-patch added

@gk.loveweb
8 years ago

Changed "IP" to "IP address".

@bradparbs
8 years ago

Fix incorrect usage of "address's"

@bradparbs
8 years ago

Fix incorrect usage of "address's" (for real this time)

#4 @jbpaul17
8 years ago

  • Keywords needs-testing added

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


8 years ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


8 years ago

#7 follow-up: @jbpaul17
8 years ago

  • Milestone changed from 4.8 to 4.8.1

Punting to 4.8.1 per today's bug scrub.

#8 in reply to: ↑ 7 @ramiy
7 years ago

Replying to jbpaul17:

Punting to 4.8.1 per today's bug scrub.

Minor version has no string changes. This is why minor version upgrades work seamlessly. This patch should be committed in 4.8

#9 @SergeyBiryukov
7 years ago

  • Milestone changed from 4.8.1 to 4.9

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


7 years ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


7 years ago

#12 @jbpaul17
7 years ago

  • Milestone changed from 4.9 to Future Release

Punting to Future Release per today's 4.8 bug scrub.

#13 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41704:

Comments: Change IP references in moderation option labels and email notifications to IP address for clarity.

Props mako09, gk.loveweb, bradparbs.
Fixes #40382.

#14 @SergeyBiryukov
7 years ago

  • Milestone changed from Future Release to 4.9

#15 @SergeyBiryukov
7 years ago

In 41705:

Multisite: Change IP references in new site or user notifications to IP address for clarity.

Props gk.loveweb, bradparbs.
See #40382.

Note: See TracTickets for help on using tickets.