WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#40431 closed enhancement (fixed)

Header Images: Improve copy

Reported by: melchoyce's profile melchoyce Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

The current Header Image copy feels a little backwards. @michelleweber has proposed improved copy for Header Images:

Click “Add new image” to upload an image file from your computer. Your theme works best with an image that’s [x]px by [x]px — you’ll be able to crop your image once you upload it for a perfect fit.

Attaching a mockup.

Attachments (3)

Screen Shot 2017-04-12 at 5.34.57 PM.png​ (375.9 KB) - added by melchoyce 8 years ago.
40431.patch​ (2.5 KB) - added by menakas 8 years ago.
Changed the copy for Header Image as per suggestion
40431.2.patch​ (2.4 KB) - added by jcc9873 8 years ago.
Modified the file as suggested in the discussion.

Download all attachments as: .zip

Change History (13)

@melchoyce
8 years ago

#1 @westonruter
8 years ago

  • Keywords needs-patch good-first-bug added

@menakas
8 years ago

Changed the copy for Header Image as per suggestion

#2 @menakas
8 years ago

  • Keywords has-patch added; needs-patch removed

#3 @westonruter
8 years ago

  • Keywords needs-patch added; has-patch removed

@menakas Thanks.

  • Translation strings should use HTML entities instead of literal UTF-8 bytes. So the patch should replace “ with “ and ” with %s”.
  • I'm not certain about including <strong> in the translated text. We'll need some input from #core-i18n.

This ticket was mentioned in ​Slack in #core-i18n by westonruter. ​View the logs.
8 years ago

@jcc9873
8 years ago

Modified the file as suggested in the discussion.

#5 @casiepa
7 years ago

Hi @westonruter , is this bug still awaiting review? It seems to have valid patches.

#6 @westonruter
7 years ago

  • Keywords has-patch added; good-first-bug needs-patch removed
  • Milestone changed from Awaiting Review to Future Release

#7 @melchoyce
7 years ago

  • Milestone changed from Future Release to 4.9

Let's try to sneak this in during Beta.

#8 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

This ticket was mentioned in ​Slack in #core-customize by melchoyce. ​View the logs.
7 years ago

#10 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41747:

Customize: Improve the wording for Header Image control intro.

Props michelleweber, menakas, jcc9873, melchoyce.
Fixes #40431.

Note: See TracTickets for help on using tickets.