![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 9 years ago
Closed 9 years ago
#40431 closed enhancement (fixed)
Header Images: Improve copy
| Reported by: | melchoyce | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.9 |
| Component: | Customize | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | ui |
Description
The current Header Image copy feels a little backwards. @michelleweber has proposed improved copy for Header Images:
Click “Add new image” to upload an image file from your computer. Your theme works best with an image that’s [x]px by [x]px — you’ll be able to crop your image once you upload it for a perfect fit.
Attaching a mockup.
Attachments (3)
Change History (13)
#3
@
9 years ago
- Keywords needs-patch added; has-patch removed
@menakas Thanks.
- Translation strings should use HTML entities instead of literal UTF-8 bytes. So the patch should replace
“with“and”with%s”. - I'm not certain about including
<strong>in the translated text. We'll need some input from #core-i18n.
This ticket was mentioned in Slack in #core-i18n by westonruter. View the logs.
9 years ago
#5
@
9 years ago
Hi @westonruter , is this bug still awaiting review? It seems to have valid patches.
#6
@
9 years ago
- Keywords has-patch added; good-first-bug needs-patch removed
- Milestone Awaiting Review → Future Release
This ticket was mentioned in Slack in #core-customize by melchoyce. View the logs.
9 years ago
Note:
See TracTickets
for help on using tickets.
Changed the copy for Header Image as per suggestion