Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 9 years ago

Closed 9 years ago

#40448 closed defect (bug) (fixed)

Semantic elements for non-link links: edit-form-advanced.php

Reported by:	Cheffheid	Owned by:	afercia
Priority:	normal	Milestone:	4.8
Component:	Editor	Version:
Severity:	normal	Keywords:	semantic-buttons has-patch has-screenshots commit
Cc:		Focuses:	accessibility

Description

The "Get Shortlink" link should be a button. Since the slug and the form this button is part of disappear when JavaScript is disabled, it should suffice to just change it to that and call it a day.

Related: #26504.

Attachments (2)

40448.patch (942 bytes ) - added by Cheffheid 9 years ago.: Swap out a tag with a button tag.
40448.diff (941 bytes ) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (7)

@Cheffheid
9 years ago

Attachment 40448.patch added

Swap out a tag with a button tag.

#1 @Cheffheid
9 years ago

Keywords semantic-buttons has-patch added

#2 @rianrietveld
9 years ago

Milestone Awaiting Review → 4.8

#3 @afercia
9 years ago

Version trunk

Worth noting as of WordPress 4.4 the Get Shortlink button is hidden by default but can be restored via filters.

@afercia
9 years ago

Attachment 40448.diff added

#4 @afercia
9 years ago

Component Administration → Editor
Keywords has-screenshots commit added

Refreshed patch.

#5 @afercia
9 years ago

Owner set to afercia
Resolution → fixed
Status new → closed

Accessibility: Make the Get Shortlink button be a real button.

Worth noting, as of WordPress 4.4, the Get Shortlink button is hidden by default
but it can be restored via filters.

Props Cheffheid.
See #26504.
Fixes #40448.

Note: See TracTickets for help on using tickets.

Download in other formats: