WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

#40461 closed defect (bug) (fixed)

Twenty Seventeen: Bump version and update changelog

Reported by: swissspidy Owned by: swissspidy
Milestone: 4.7.4 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: Cc:

Attachments (3)

40264.diff (5.8 KB) - added by swissspidy 6 months ago.
40264-no-versions.diff (2.1 KB) - added by swissspidy 6 months ago.
40461.2.patch (6.0 KB) - added by davidakennedy 6 months ago.
Update changelog to to link to Codex pages, like other default themes.

Download all attachments as: .zip

Change History (9)

@swissspidy
6 months ago

#2 @swissspidy
6 months ago

  • Keywords has-patch added; needs-patch removed

40264-no-versions.diff updates the readme and style.css.

40264.diff includes changes to the @version annotations in the file headers as well. Nothing changed in that regard in version 1.1 of the theme, so I'm not sure if I missed anything.

Background on @version: https://github.com/WordPress/twentyseventeen/issues/72

These version numbers would be updated only when the file is updated. With this information we can check if a file is outdated in a child theme.

@davidakennedy @karmatosed Would be great to get your feedback on this so we can update Twenty Seventeen together with the WordPress 4.7.4 release.

@davidakennedy
6 months ago

Update changelog to to link to Codex pages, like other default themes.

#3 @davidakennedy
6 months ago

@swissspidy Your patch with the versions looks good to me. I've tweaked it to link to the Codex changelog page, instead of doing a long changelog in the theme. This is consistent with how we do changelogs for other default themes. See: https://codex.wordpress.org/Twenty_Seventeen_Theme_Changelog

And https://codex.wordpress.org/Twenty_Fifteen_Theme_Changelog, as an example.

With the @version thing, thanks for catching the ones I missed. The only thing I wasn't sure about is whether they should be 1.1, counting up, or as you did it, making them match the version of the theme the change was made. I think your way is probably more sustainable.

#4 @swissspidy
6 months ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 40472:

Twenty Seventeen: Bump version and update the changelog.

Updates changelog to link to Codex pages, like other default themes.

Props swissspidy, davidakennedy.
Fixes #40461.

#5 @swissspidy
6 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#6 @swissspidy
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 40473:

Twenty Seventeen: Bump version and update the changelog.

Updates changelog to link to Codex pages, like other default themes.

Props swissspidy, davidakennedy.
Fixes #40461.

Merges [40472] to the 4.7 branch.

Note: See TracTickets for help on using tickets.