Opened 7 years ago
Closed 7 years ago
#40461 closed defect (bug) (fixed)
Twenty Seventeen: Bump version and update changelog
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.7.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch fixed-major |
Focuses: | Cc: |
Description
Changes so far: https://core.trac.wordpress.org/log/branches/4.7/src/wp-content/themes/twentyseventeen?stop_rev=40373. #40264 will land soon as well.
Attachments (3)
Change History (9)
#2
@
7 years ago
- Keywords has-patch added; needs-patch removed
40264-no-versions.diff updates the readme and style.css.
40264.diff includes changes to the @version
annotations in the file headers as well. Nothing changed in that regard in version 1.1 of the theme, so I'm not sure if I missed anything.
Background on @version
: https://github.com/WordPress/twentyseventeen/issues/72
These version numbers would be updated only when the file is updated. With this information we can check if a file is outdated in a child theme.
@davidakennedy @karmatosed Would be great to get your feedback on this so we can update Twenty Seventeen together with the WordPress 4.7.4 release.
#3
@
7 years ago
@swissspidy Your patch with the versions looks good to me. I've tweaked it to link to the Codex changelog page, instead of doing a long changelog in the theme. This is consistent with how we do changelogs for other default themes. See: https://codex.wordpress.org/Twenty_Seventeen_Theme_Changelog
And https://codex.wordpress.org/Twenty_Fifteen_Theme_Changelog, as an example.
With the @version
thing, thanks for catching the ones I missed. The only thing I wasn't sure about is whether they should be 1.1
, counting up, or as you did it, making them match the version of the theme the change was made. I think your way is probably more sustainable.
#4
@
7 years ago
- Owner set to swissspidy
- Resolution set to fixed
- Status changed from new to closed
In 40472:
can you look at https://wordpress.org/support/topic/twenty-seventeen-minor-defects-on-4-7-1-rc1/