Twenty Seventeen: Incorrect heading hierarchy for front page sections

[celloexpressions]

When the posts page is used as a front page section, it displays recent post titles. These should be a sub-level of hierarchy within the posts-page front page section. The posts-page section title is an h2, so the individual post titles should be h3.

Issue found by @joedolson in the Dynamic Seventeen theme accessibility-ready review.

[celloexpressions]

Use h3 when the excerpt template is being used within a front page section.

[swissspidy]

When displaying regular posts on the front page, i.e. not within a section, the page title ("Posts") is a <h2> while the individual post titles are <h2> as well. This patch doesn't address this, even though it basically is the same issue.

[davidakennedy]

Good catch everyone! I missed this in the accessibility review I did.

I agree with @swissspidy that we should make this change for when posts are displayed on the front page. In this case, they'll be a <h3>, but I assume the font size should remain the same size as the <h2>s are now – so the visual hierarchy is the same. What do you think @melchoyce?

[melchoyce]

Replying to davidakennedy:

I agree with @swissspidy that we should make this change for when posts are displayed on the front page. In this case, they'll be a <h3>, but I assume the font size should remain the same size as the <h2>s are now – so the visual hierarchy is the same. What do you think @melchoyce?

This would be my ideal approach 👍

[swissspidy]

@melchoyce @davidakennedy With 4.7.4 now being planned for next Tuesday, do you think this one could be made ready for 4.7.4? We already have a few fixes for Twenty Seventeen in this release that might warrant a new version.

[davidakennedy]

With 4.7.4 now being planned for next Tuesday, do you think this one could be made ready for 4.7.4?

@swissspidy I think so. Initial patch incoming. I'll take a closer look at this tomorrow morning to make sure I didn't miss anything, and have @laurelfulford review it if she can.

[davidakennedy]

When displaying regular posts on the front page, make post titles <h3> to stay within a hierarchy.

[swissspidy]

Thanks @davidakennedy! The latest patch looks good to me.

[laurelfulford]

It looks good to me, too, @davidakennedy!

[swissspidy]

@davidakennedy After having a second look at 40264.2.patch​ , why is the @version not updated in all affected template files?

Should we perhaps do such a change in a separate ticket similar to #39489?

[swissspidy]

Created a new ticket for the changelog: #40461

[sami.keijonen]

Tested the 40264.2.patch and it looks good. Not sure about the Version stuff.

[swissspidy]

Alright, let's handle the version thing in #40461

[swissspidy]

In 40458:

Twenty Seventeen: Correct heading hierarchy for posts on the front page.

When the posts page is on the front page or within a front page section, the heading hierarchy for the individual post titles needs to be adjusted accordingly.

Props joedolson, celloexpressions, davidakennedy.
Fixes #40264.

[swissspidy]

In 40459:

Twenty Seventeen: Correct heading hierarchy for posts on the front page.

When the posts page is on the front page or within a front page section, the heading hierarchy for the individual post titles needs to be adjusted accordingly.

Props joedolson, celloexpressions, davidakennedy.
Fixes #40264.

Merges [40458] to the 4.7 branch.