WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 12 months ago

#40468 closed defect (bug) (fixed)

Accessibility glitch when viewing/editing Attachment Details

Reported by: Presskopp Owned by: pento
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Media Keywords: commit
Focuses: ui, accessibility, javascript Cc:
PR Number:

Description

This is related to #38759

Attachments (1)

dead_link.mp4 (791.1 KB) - added by Presskopp 3 years ago.

Download all attachments as: .zip

Change History (16)

@Presskopp
3 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 years ago

#2 @rianrietveld
3 years ago

  • Focuses administration added; accessibility removed

@Presskopp
Can you be more specific?
Did you want to change the value for uploaded by?
At the moment that's not a field you can change.
Or do you mean something else?

#3 @joedolson
3 years ago

Both the "uploaded to" and "uploaded by" fields are entirely contained within label elements, with no associated input. This is definitely semantically invalid. For better accessibility, the labels should be separated from the value, with a readonly input field associated with the value.

#4 @Presskopp
3 years ago

1) @rianrietveld I mean you shouldn't get a pointer cursor when there's nothing to click. In the area right to the "Uploaded By"-value I have a pointer for nothing.

2) It's stated Required fields are marked * , but there are no required fields. We don't need this here.

3) Also Dimensions lacks a unit, see #38932

#5 @rianrietveld
3 years ago

@Presskopp Thanks, now I understand.
Added label accessibility back again.

#6 @rianrietveld
2 years ago

  • Focuses accessibility added

#7 @Presskopp
2 years ago

Digging into 2) confused me (see edits of this post). But I know now there has been a related ticket in #34944

Last edited 2 years ago by Presskopp (previous) (diff)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 years ago

#9 @afercia
2 years ago

  • Focuses ui javascript added; administration removed
  • Milestone changed from Awaiting Review to Future Release
  • Version 4.7.3 deleted

At least the labels should be fixed, moving to Future Release.

#10 @afercia
21 months ago

  • Milestone changed from Future Release to 5.0
  • Owner set to afercia
  • Status changed from new to assigned

Will be fixed with the patch on #38759.

#11 @afercia
21 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42444:

Accessibility: Media: Improve the usage of a few label elements in the media templates.

Label elements should only be used for labelable elements.

  • Uploaded By and Uploaded To aren't form controls and shouldn't be associated with labels
  • changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)

Props Presskopp, afercia.
Fixes #38759, #40468.

#12 @johnbillion
12 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[42444] should be merged into 5.0

#13 @afercia
12 months ago

  • Owner afercia deleted
  • Status changed from reopened to assigned

#14 @pento
12 months ago

  • Keywords commit added

Yah, this is fine to backport to 5.0.

#15 @pento
12 months ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from assigned to closed

In 43829:

Accessibility: Media: Improve the usage of a few label elements in the media templates.

Label elements should only be used for labelable elements.

  • Uploaded By and Uploaded To aren't form controls and shouldn't be associated with labels
  • changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)

Merges [42444] to the 5.0 branch.

Props Presskopp, afercia.
Fixes #38759, #40468.

Note: See TracTickets for help on using tickets.