Make WordPress Core

Opened 13 months ago

Closed 4 months ago

#40468 closed defect (bug) (fixed)

Accessibility glitch when viewing/editing Attachment Details

Reported by: Presskopp Owned by: afercia
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Media Keywords:
Focuses: ui, accessibility, javascript Cc:


This is related to #38759

Attachments (1)

dead_link.mp4 (791.1 KB) - added by Presskopp 13 months ago.

Download all attachments as: .zip

Change History (12)

13 months ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.

13 months ago

#2 @rianrietveld
13 months ago

  • Focuses administration added; accessibility removed

@Presskopp Can you be more specific? Did you want to change the value for uploaded by? At the moment that's not a field you can change. Or do you mean something else?

#3 @joedolson
13 months ago

Both the "uploaded to" and "uploaded by" fields are entirely contained within label elements, with no associated input. This is definitely semantically invalid. For better accessibility, the labels should be separated from the value, with a readonly input field associated with the value.

#4 @Presskopp
13 months ago

1) @rianrietveld I mean you shouldn't get a pointer cursor when there's nothing to click. In the area right to the "Uploaded By"-value I have a pointer for nothing.

2) It's stated Required fields are marked * , but there are no required fields. We don't need this here.

3) Also Dimensions lacks a unit, see #38932

#5 @rianrietveld
13 months ago

@Presskopp Thanks, now I understand. Added label accessibility back again.

#6 @rianrietveld
13 months ago

  • Focuses accessibility added

#7 @Presskopp
13 months ago

Digging into 2) confused me (see edits of this post). But I know now there has been a related ticket in #34944

Last edited 13 months ago by Presskopp (previous) (diff)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.

13 months ago

#9 @afercia
13 months ago

  • Focuses ui javascript added; administration removed
  • Milestone changed from Awaiting Review to Future Release
  • Version 4.7.3 deleted

At least the labels should be fixed, moving to Future Release.

#10 @afercia
4 months ago

  • Milestone changed from Future Release to 5.0
  • Owner set to afercia
  • Status changed from new to assigned

Will be fixed with the patch on #38759.

#11 @afercia
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 42444:

Accessibility: Media: Improve the usage of a few label elements in the media templates.

Label elements should only be used for labelable elements.

  • Uploaded By and Uploaded To aren't form controls and shouldn't be associated with labels
  • changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)

Props Presskopp, afercia.
Fixes #38759, #40468.

Note: See TracTickets for help on using tickets.