Accessibility glitch when viewing/editing Attachment Details

[Presskopp]

This is related to #38759

[rianrietveld]

@Presskopp
Can you be more specific?
Did you want to change the value for uploaded by?
At the moment that's not a field you can change.
Or do you mean something else?

[joedolson]

Both the "uploaded to" and "uploaded by" fields are entirely contained within label elements, with no associated input. This is definitely semantically invalid. For better accessibility, the labels should be separated from the value, with a readonly input field associated with the value.

[Presskopp]

1) @rianrietveld I mean you shouldn't get a pointer cursor when there's nothing to click. In the area right to the "Uploaded By"-value I have a pointer for nothing.

2) It's stated Required fields are marked * , but there are no required fields. We don't need this here.

3) Also Dimensions lacks a unit, see #38932

[rianrietveld]

@Presskopp Thanks, now I understand.
Added label accessibility back again.

[Presskopp]

Digging into 2) confused me (see edits of this post). But I know now there has been a related ticket in #34944

[afercia]

At least the labels should be fixed, moving to Future Release.

[afercia]

Will be fixed with the patch on #38759.

[afercia]

In 42444:

Accessibility: Media: Improve the usage of a few label elements in the media templates.

Label elements should only be used for labelable elements.

• Uploaded By and Uploaded To aren't form controls and shouldn't be associated with labels
• changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)

Props Presskopp, afercia.
Fixes #38759, #40468.

[johnbillion]

[42444] should be merged into 5.0

[pento]

Yah, this is fine to backport to 5.0.

[pento]

In 43829:

Accessibility: Media: Improve the usage of a few label elements in the media templates.

Label elements should only be used for labelable elements.

• Uploaded By and Uploaded To aren't form controls and shouldn't be associated with labels
• changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)

Merges [42444] to the 5.0 branch.

Props Presskopp, afercia.
Fixes #38759, #40468.