the wpImageFormSubmit JS event has disappeared from the tinymce image plugin

[imath]

Since [40583] some specific WordPress code has disappeared from the src/wp-includes/js/tinymce/plugins/image/plugin.js file.

There used to be an event that was fired to inform the regular image plugin form was submitted: wpImageFormSubmit. I was listening to it in one of my plugin :(

I don't know if it could have an impact on WordPress Core more globally, but i thought i had to let you know.

[imath]

The specific WordPress code which disappeared.

[ocean90]

@azaozz Was there a reason for that? Looks like an oversight to me.

[azaozz]

This was an old "hack" to the TinyMCE image plugin left over from the initial implementation in WordPress 3.9. There were few more events added in there. It probably should have been removed long time ago (note that this plugin is not used by default in WP). In TinyMCE 4.6 the plugin was changed quite significantly to keep maintaining this hack.

If a third party plugin still needs the changed default image plugin, it would be best to include it and add it as external plugin to TinyMCE.

[ocean90]

@imath What's the name of your plugin?

Should we search the plugin directory for wpImageFormSubmit and inform the plugin authors?

[imath]

Hi @ocean90

It's WP Idea Stream. But i've just updated it so that it doesn't use this event anymore. I've fixed ​my issue using the setcontent event.

I don't know if there are some plugins still using it, i don't know what's best to warn plugin authors. Maybe a Post in Make.WordPress.org is enough.

[SergeyBiryukov]

Replying to ocean90:

Should we search the plugin directory for wpImageFormSubmit and inform the plugin authors?

Only 4 distinct results in the plugin directory:

media-credit/admin/js/tinymce4/media-credit-tinymce.js
media-credit/admin/js/tinymce4/media-credit-tinymce.min.js
wa-fronted/js/min/scripts.min.js
wa-fronted/js/tinymce/tinymce.image.js
wp-front-end-editor/js/tinymce.image.js
wp-idea-stream/js/featured-images.js
wp-idea-stream/js/featured-images.min.js

[azaozz]

It appears this doesn't break any of these plugins. After all it was an old "private event hack" for a TinyMCE plugin that is not used by default in WordPress :)