Make WordPress Core

Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#41004 closed defect (bug) (fixed)

Docs issue for Downloading a Patch

Reported by: rinkuyadav999's profile rinkuyadav999 Owned by:
Milestone: WordPress.org Priority: normal
Severity: normal Version:
Component: WordPress.org Site Keywords:
Focuses: docs Cc:

Description

Hi

There is a tutorial for 'working with patches' and a section 'applying a patch': https://make.wordpress.org/core/handbook/tutorials/working-with-patches/#applying-a-patch

  1. Downloading a Patch

.
.
.
To download a patch, right-click on the filename in the Attachments section of the ticket (just below the Description section), select Save Link As in the context menu, and save it to a folder called patches.

Issue: When i follow above steps (Save Link As) to save patch, it saves patch but it does not apply. but when i click on Download icon, it save patch and apply without any issue. So i think, correct method to save patch is 'Click on Download Icon to Save patch' instead Save Link As.

System: Window 10 (64 bit), Firefox 53.0.3 (32 bit), TortoiseSVN 1.9.5, Build 27581 - 64 Bit

Also i have notice that file downloaded by download icon is different than downloaded by save link as...

Attachments (2)

downloaded-by-icon.diff.txt (1.0 KB) - added by rinkuyadav999 8 years ago.
Patch downloaded by download icon
downloaded-by-save-as-link.diff.txt (24.9 KB) - added by rinkuyadav999 8 years ago.
Patch downloaded by save link as

Download all attachments as: .zip

Change History (4)

@rinkuyadav999
8 years ago

Patch downloaded by download icon

@rinkuyadav999
8 years ago

Patch downloaded by save link as

#1 @rinkuyadav999
8 years ago

  • Keywords dev-feedback added

#2 @SergeyBiryukov
7 years ago

  • Component changed from General to WordPress.org site
  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to WordPress.org
  • Resolution set to fixed
  • Status changed from new to closed

Hi @rinkuyadav999, thank you for the ticket!

You're right, the instructions were incorrect. I've updated that paragraph and changed the screenshot.

In the future, please report any issues with WordPress.org handbooks on Meta Trac or in the #docs channel on Slack. Thanks!

Last edited 7 years ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.