WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#41169 closed defect (bug) (fixed)

Inaccurate descriptive text when adding a new site

Reported by: johnbillion Owned by: nishitlangaliya
Milestone: 4.9 Priority: low
Severity: minor Version: 4.3
Component: Networks and Sites Keywords: good-first-bug has-patch
Focuses: administration, multisite Cc:

Description

When adding a new site from Network Admin -> Sites -> Add New, the following help text is shown:

The username and password will be mailed to this email address.

This text is not accurate since [33023]. The user will be emailed their username and a password reset link.

Attachments (2)

41169.patch (892 bytes) - added by nishitlangaliya 4 years ago.
Fixes #41169
41169-NEW.patch (898 bytes) - added by nishitlangaliya 4 years ago.
fixes as per suggestion #41169

Download all attachments as: .zip

Change History (10)

@nishitlangaliya
4 years ago

Fixes #41169

#1 @nishitlangaliya
4 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core by nishitlangaliya. View the logs.


4 years ago

#3 @swissspidy
4 years ago

  • Owner set to nishitlangaliya
  • Status changed from new to assigned

The text is missing some articles. Should be something more like this:

The username and a link to reset the password will be mailed to this email address.


Marking this good-first-bug as 'claimed'.

#4 @nishitlangaliya
4 years ago

@swissspidy ,

Thanks for suggestion I will do and update for the same :)

@nishitlangaliya
4 years ago

fixes as per suggestion #41169

#5 @nishitlangaliya
4 years ago

@swissspidy ,

As per your suggestion I have uploaded updated patch please review it when you get a chance.

Thanks.

This ticket was mentioned in Slack in #core-multisite by greatislander. View the logs.


4 years ago

#7 @flixos90
4 years ago

  • Milestone changed from Awaiting Review to 4.9

As discussed in today's ticket scrub, the message should be "The username and a link to set the password will be mailed to this email address." (set instead of reset, since the new user doesn't really reset their password)

#8 @flixos90
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41064:

Multisite: Fix a user-facing message when adding a new site with a new user as admin.

Previously the message would falsely state that the username and password would be sent to the new user. It is actually a link to set the password that they receive in the email.

Props nishitlangaliya.
Fixes #41169.

Note: See TracTickets for help on using tickets.