Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#41176 closed defect (bug) (fixed)

PHP DocBlock spilling into HTML/JS

Reported by: chrisvendiadvertisingcom's profile chris@… Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.8
Component: Login and Registration Keywords:
Focuses: Cc:

Description

This is a follow-up to #40301. The original patch's PHP DocBlock commenting is outside of the PHP tags so it is appearing in the HTML source. The specific source section is JS so the browser just ignores it as a JS comment but it should probably be removed.

The attached patch moves the comments back into PHP.

Attachments (1)

wp-login.diff (619 bytes) - added by chris@… 7 years ago.

Download all attachments as: .zip

Change History (4)

@chris@…
7 years ago

#1 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.9

#2 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 40954:

Login and Registration: Prevent the enable_login_autofocus filter DocBlock from spilling into JS code.

Props chris@….
Fixes #41176.

#3 @SergeyBiryukov
6 years ago

#41912 was marked as a duplicate.

Note: See TracTickets for help on using tickets.