WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 23 months ago

#41428 new defect (bug)

Editor: long URLs are not broken in notifications

Reported by: eliorivero Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.8
Component: Editor Keywords: close
Focuses: ui, administration Cc:
PR Number:

Description

I have Google Fonts blocked in /etc/hosts and I get this notification when I edit a post, which is fine, except by the fact that it overflows:

https://cldup.com/t7l1Z2fRi0-3000x3000.png

The attached patch solves this by allowing to break the long string and it looks like this:

https://cldup.com/sMxEn8Cxn3-3000x3000.png

Attachments (1)

41428.diff (349 bytes) - added by eliorivero 2 years ago.
Allow to break long text strings in TinyMCE notifications

Download all attachments as: .zip

Change History (9)

@eliorivero
2 years ago

Allow to break long text strings in TinyMCE notifications

#1 @melchoyce
2 years ago

Could we potentially also style these to match other core notifications, either right above the editor or inline? (Though maybe that doesn't matter so much because of Gutenberg. Pinging @joen for any thoughts there.)

#2 @Joen
2 years ago

We're still using TinyMCE in Gutenberg. We use it to power almost every textfield. So if this is a notification that is generated by Tiny, it'll still show up. Might be worth looping in @afraithe?

This ticket was mentioned in Slack in #core-tinymce by afraithe. View the logs.


2 years ago

#4 @eliorivero
2 years ago

@Joen this notification is not showing up in Gutenberg.

#5 @ocean90
2 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 4.9 to 4.8

Related: #40893

#6 @dmsnell
23 months ago

It appears like this has been fixed in Gutenberg but still remains an issue outside of there. Is there any reason not to accept this patch and fix the remaining cases? @melchoyce

@afercia has the internal issue from TinyMCE been resolved that was mentioned in Slack?

#7 @afercia
23 months ago

@dmsnell I have no idea :) Best person to ask to: @azaozz I guess.

#8 @azaozz
23 months ago

  • Keywords close added; needs-patch good-first-bug removed

@dmsnell this was fixed upstream some time ago in TinyMCE 4.6.6, see https://github.com/tinymce/tinymce/blob/master/changelog.txt#L102. I can't reproduce it in trunk and 4.9, where did you see these warnings?

Note: See TracTickets for help on using tickets.