![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#41432 closed feature request (fixed)
Allow ircs protocol handler in default allowed whitelist for hyperlinks
| Reported by: | arealnobrainer | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.6 |
| Component: | Formatting | Version: | 3.3 |
| Severity: | normal | Keywords: | good-first-bug has-patch has-unit-tests |
| Cc: | Focuses: |
Description
Would it not be an idea to allow for protocol ircs:// in default allowed whitelist of protocols in WP ?
Today only irc:// is allowed.
But not the secure handler ircs:// ...
Change History (12)
This ticket was mentioned in Slack in #core by noisysocks. View the logs.
6 years ago
#2
@
6 years ago
- Keywords needs-patch good-first-bug added
- Milestone Awaiting Review → Future Release
This ticket was mentioned in Slack in #core by ctmartin0. View the logs.
6 years ago
This ticket was mentioned in PR #554 on WordPress/wordpress-develop by ct-martin.
6 years ago
#4
- Keywords has-patch has-unit-tests added; needs-patch removed
Add the irc6 and ircs to list of allowed protocols for links
Trac ticket: https://core.trac.wordpress.org/ticket/41432
TimothyBJacobs commented on PR #554:
6 years ago
#5
Thanks for the patch @ct-martin!
It'd be good to add an @since documentation noting that new allowed protocols. See the PHP Doc Standards for reference.
ct-martin commented on PR #554:
6 years ago
#6
@TimothyBJacobs from what I understand, @since should be the version at which the change is available. The Trac ticket says Future Release, but should I put 5.6.0? Thanks!
TimothyBJacobs commented on PR #554:
6 years ago
#7
Yep! 5.6.0.
ct-martin commented on PR #554:
6 years ago
#8
@TimothyBJacobs thanks! Added and pushed changes (rebased on master)
TimothyBJacobs commented on PR #554:
6 years ago
#12
Fixed in 4ad4eea. Thanks again for the patch @ct-martin!
Thanks @arealnobrainer, and sorry it's taken so long for you to get a response!
This definitely sounds worthwhile - we should add
irc6://as well while we're at it.