WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 12 months ago

Last modified 12 months ago

#41432 closed feature request (fixed)

Allow ircs protocol handler in default allowed whitelist for hyperlinks

Reported by: arealnobrainer Owned by:
Milestone: 5.6 Priority: normal
Severity: normal Version: 3.3
Component: Formatting Keywords: good-first-bug has-patch has-unit-tests
Focuses: Cc:

Description

Would it not be an idea to allow for protocol ircs:// in default allowed whitelist of protocols in WP ?

Today only irc:// is allowed.
But not the secure handler ircs:// ...

Change History (12)

This ticket was mentioned in Slack in #core by noisysocks. View the logs.


12 months ago

#2 @markparnell
12 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

Thanks @arealnobrainer, and sorry it's taken so long for you to get a response!

This definitely sounds worthwhile - we should add irc6:// as well while we're at it.

This ticket was mentioned in Slack in #core by ctmartin0. View the logs.


12 months ago

This ticket was mentioned in PR #554 on WordPress/wordpress-develop by ct-martin.


12 months ago

  • Keywords has-patch has-unit-tests added; needs-patch removed

Add the irc6 and ircs to list of allowed protocols for links

Trac ticket: https://core.trac.wordpress.org/ticket/41432

#5 @prbot
12 months ago

TimothyBJacobs commented on PR #554:

Thanks for the patch @ct-martin!

It'd be good to add an @since documentation noting that new allowed protocols. See the PHP Doc Standards for reference.

#6 @prbot
12 months ago

ct-martin commented on PR #554:

@TimothyBJacobs from what I understand, @since should be the version at which the change is available. The Trac ticket says Future Release, but should I put 5.6.0? Thanks!

#7 @prbot
12 months ago

TimothyBJacobs commented on PR #554:

Yep! 5.6.0.

#8 @prbot
12 months ago

ct-martin commented on PR #554:

@TimothyBJacobs thanks! Added and pushed changes (rebased on master)

#9 @TimothyBlynJacobs
12 months ago

  • Milestone changed from Future Release to 5.6
  • Version set to 3.3

IANA references: irc6 and ircs.

#10 @SergeyBiryukov
12 months ago

  • Component changed from General to Formatting

#11 @TimothyBlynJacobs
12 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed by [49055].

#12 @prbot
12 months ago

TimothyBJacobs commented on PR #554:

Fixed in 4ad4eea. Thanks again for the patch @ct-martin!

Note: See TracTickets for help on using tickets.