WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Last modified 7 months ago

#41583 new enhancement

Menus Administration screen, menu items are always loaded even when not needed

Reported by: webgeekconsulting's profile webgeekconsulting Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.8.1
Component: Menus Keywords: has-patch dev-feedback 2nd-opinion
Focuses: performance Cc:

Description (last modified by welcher)

On the Menus Administration screen menu items are always loaded. For performance, menu items should only be loaded when editing an existing menu and not on the locations tabs or when adding a new menu item. I've attached a patch that fixes this.

Attachments (1)

nav-menus-performance.diff​ (1.2 KB) - added by webgeekconsulting 7 years ago.

Download all attachments as: .zip

Change History (3)

@webgeekconsulting
7 years ago

#1 @welcher
7 years ago

  • Description modified (diff)
  • Keywords has-patch dev-feedback 2nd-opinion added

@webgeekconsulting thanks for the ticket and the patch!

The patch applied cleanly for me and the unit tests pass as well. I would like to have @westonruter review it for any potential Customizer issues before moving it forward.

#2 @pbearne
7 months ago

Does this need a re-fresh?

Note: See TracTickets for help on using tickets.