WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 5 weeks ago

#41666 reviewing defect (bug)

i18n: Use %s placeholders in wp-http

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Old translation string:

  • Could not open handle for fopen() to %s

New translation string:

  • Could not open handle for %1$s to %2$s.

The function can be mistakenly changes by the translator. The best practice is to replace the fopen() function with a %s placeholder.

The patch also adds a period at the end of the sentence and adds translators comments.

Attachments (3)

fopen.png (23.5 KB) - added by ramiy 5 weeks ago.
41666.patch (1.6 KB) - added by ramiy 5 weeks ago.
41666.2.patch (1.6 KB) - added by ramiy 5 weeks ago.
add <code> tags around the function name

Download all attachments as: .zip

Change History (5)

@ramiy
5 weeks ago

@ramiy
5 weeks ago

#1 @ramiy
5 weeks ago

  • Keywords has-patch added

#2 @SergeyBiryukov
5 weeks ago

  • Milestone changed from Awaiting Review to 4.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

@ramiy
5 weeks ago

add <code> tags around the function name

Note: See TracTickets for help on using tickets.